Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature Request] Promises or raw string support #59

Open
mgrybyk opened this issue May 5, 2024 · 0 comments
Open

[Feature Request] Promises or raw string support #59

mgrybyk opened this issue May 5, 2024 · 0 comments
Labels
enhancement help wanted

Comments

@mgrybyk
Copy link

mgrybyk commented May 5, 2024 •
edited
Loading

Actual Behavior

const json2 = csvToJson.fieldDelimiter(',').getJsonFromCsv(sourceReportDir).

getJsonFromCsv uses synchronous file API.

Description

The synchronous API is not suitable for modern Promise apps.

Introduce Promise API or let users read files on their own and allow passing raw string.

Specifications

  • Version: 2.46.0
@mgrybyk mgrybyk changed the title [Feature Request] Promises support [Feature Request] Promises or raw string support May 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@iuccio @mgrybyk