You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently the vfs.getFile method returns the body of a file as a raw argument. This is fine for small text files, but less optimal for binary files. It's also a different behavior to the dump and zip modules that pipe responses to a write stream.
I recommend adding a vfs.downloadFile method.
The text was updated successfully, but these errors were encountered:
Would downloadFile return a stream, or would it take a file path and write the file directly to that path? I think having an API for both would be useful. Maybe readFile would give you a stream, downloadFile would take a path to write to, and getFile would work like it does today?
I think vfs.downloadFile should behave the same as dump.download and zip.download, which is to write to a specified file path. A readFile method that provides a stream makes sense too. Perhaps zip and dump should follow suit?
Currently the
vfs.getFile
method returns the body of a file as a raw argument. This is fine for small text files, but less optimal for binary files. It's also a different behavior to thedump
andzip
modules that pipe responses to a write stream.I recommend adding a
vfs.downloadFile
method.The text was updated successfully, but these errors were encountered: