Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

stopDownload() doesn't return a Promise #37

Closed
af opened this issue Dec 21, 2015 · 2 comments
Closed

stopDownload() doesn't return a Promise #37

af opened this issue Dec 21, 2015 · 2 comments

Comments

@af
Copy link
Contributor

af commented Dec 21, 2015

The readme indicates that it should, but I'm not sure if that's a docs error. Every other call in the API returns a Promise, so I'm guessing that would be the intended behaviour.
@cjdell
Copy link
Collaborator

cjdell commented Dec 21, 2015

Good spot, this method is effectively synchronous so it doesn't return a promise. I've corrected the README to reflect this. Thanks

@cjdell cjdell closed this as completed Dec 21, 2015
@af
Copy link
Contributor Author

af commented Dec 21, 2015

Makes sense, thanks!

@stebogit stebogit mentioned this issue Aug 30, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@af @cjdell