Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rel="manifest" and cookies #248

Closed
alecmev opened this issue Nov 12, 2018 · 2 comments
Closed

rel="manifest" and cookies #248

alecmev opened this issue Nov 12, 2018 · 2 comments

Comments

@alecmev
Copy link
Contributor

alecmev commented Nov 12, 2018

As per spec, cookies aren't being sent with rel="manifest" requests. Currently, the only remedy is to add crossOrigin="use-credentials" to the link tag. I'm able to do that using this snippet:

Favicons.config.html.android["link[rel='manifest'][href$='manifest.json']"] =
  "<link rel='manifest' href='manifest.json' crossOrigin='use-credentials'>"

But this is a dirty hack and will inevitably break in the future. Would you mind having a public option for this? E.g. loadManifestWithCredentials or something like that? I'm not suggesting to make it a default because some may desire to keep the credentials omitted.

@alexander-akait
Copy link
Member

@jeremejevs feel free to send a PR

@alecmev
Copy link
Contributor Author

alecmev commented Nov 12, 2018

@evilebottnawi Done: #249

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants