Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unpin test packages versions #90

Open
efiop opened this issue Nov 8, 2022 · 4 comments
Open

unpin test packages versions #90

efiop opened this issue Nov 8, 2022 · 4 comments

Comments

@efiop
Copy link
Contributor

efiop commented Nov 8, 2022

No description provided.

@skshetry
Copy link
Member

skshetry commented Nov 9, 2022

Could you elaborate?
I prefer it pinned because if you come to the project after 2-3 months, it'll still work as it did before. We had lots of issues with pytest updates, which is why we started pinning them in dvc (mostly pytest-xdist/pytest/pytest-cov and pytest-timeout not mixing well). Although no strong opinion, pytest is a stable/mature framework.

@skshetry
Copy link
Member

skshetry commented Nov 9, 2022

Also we cannot provide backward compatibility in pytest-servers and pytest-test-utils at this time, so they should always be pinned.

@efiop
Copy link
Contributor Author

efiop commented Nov 10, 2022

Just writing down an item from retro. The strict == on pytest seems a bit unnecessary in the template, but as we've discussed privately, might be worth keeping to ensure that things will at least work initially. Feel free to close.

@skshetry
Copy link
Member

I have changed my mind here. I have started unpinning on some repositories, so we'll likely do same in the template here. Whatever decision gets made downstream is maintainer's responsibility, and at their descretion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants