Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI Integration Checklist #116

Open
7 of 8 tasks
madisonb opened this issue Apr 13, 2017 · 4 comments
Open
7 of 8 tasks

UI Integration Checklist #116

madisonb opened this issue Apr 13, 2017 · 4 comments

Comments

@madisonb
Copy link
Collaborator

madisonb commented Apr 13, 2017

Checklist for items that I know need worked on before the ui branch can be merged into the dev branch

  • Create documentation
  • Add offline unit tests
  • Add online integration tests
  • Add tests to run_*_tests.sh
  • Can we add actual ui tests? (aka Selenium or some other framework)
  • Can we use the local flask app to pass requests to the Rest Endpoint, instead of the browser? (only exposing the UI port on the cluster)
  • Build out primitive functionality to submit a crawl request, or get basic information about the cluster
  • Ensure travis can run the unit tests

This comment here outlines FULL functionality, however I don't think we need that to provide a basic UI for the cluster to be merged into dev.

This checklist will be updated as we come across other smaller items that prevent the ui branch from merging into dev

@damienkilgannon
Copy link
Contributor

damienkilgannon commented Jul 17, 2017

This PR #129 satisfies the following items from the above checklist; although additional unit tests are required for better code coverage.

  • Create documentation
  • Add offline unit tests
  • Add online integration tests
  • Add tests to run_*_tests.sh
  • Can we add actual ui tests? (aka Selenium or some other framework)
  • Can we use the local flask app to pass requests to the Rest Endpoint, instead of the browser? (only exposing the UI port on the cluster)
  • Build out primitive functionality to submit a crawl request, or get basic information about the cluster
  • Ensure travis can run the unit tests

@backtrack-5
Copy link

backtrack-5 commented Mar 29, 2018

Hi @madisonb , @damienkilgannon ,

I have written UI test using selenium and python for all pages available in Scrapy Cluster. (index, Kafka, Redis and Crawler)

and created my PR #174

Added my code under : ~ui\tests\uitest

Please let me know if i need to do any changes

Thanks,

@damienkilgannon
Copy link
Contributor

Hi @sornalingam nice .... been a while since I worked on this, I must get back to it. I think the branch you created the PR on is the most appropriate. I will check out your branch in the next day or two and have a look.

@backtrack-5
Copy link

Hi @damienkilgannon,
Thanks, I have commited my new code. Please have a look when you get a chance and let me know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants