From 384e2a4de650b6e8f42784d90df4d021898a5109 Mon Sep 17 00:00:00 2001 From: Travis Clarke Date: Wed, 22 Apr 2020 14:23:27 -0700 Subject: [PATCH] Run update-ref-docs (dr) on presubmit of istio.io and make it required --- .../istio.io/istio.istio.io.master.gen.yaml | 44 +++++++++++++++++++ .../istio/istio/istio.istio.master.gen.yaml | 43 ------------------ prow/config/jobs/istio.io.yaml | 13 ++++++ prow/config/jobs/istio.yaml | 13 ------ 4 files changed, 57 insertions(+), 56 deletions(-) diff --git a/prow/cluster/jobs/istio/istio.io/istio.istio.io.master.gen.yaml b/prow/cluster/jobs/istio/istio.io/istio.istio.io.master.gen.yaml index eea3818d8e8..d952f09ea53 100644 --- a/prow/cluster/jobs/istio/istio.io/istio.istio.io.master.gen.yaml +++ b/prow/cluster/jobs/istio/istio.io/istio.istio.io.master.gen.yaml @@ -252,3 +252,47 @@ presubmits: name: cgroup - emptyDir: {} name: docker-root + - always_run: true + annotations: + testgrid-dashboards: istio_istio.io + branches: + - ^master$ + decorate: true + extra_refs: + - base_ref: master + org: istio + path_alias: istio.io/test-infra + repo: test-infra + name: update-ref-docs-dry-run_istio.io + optional: true + path_alias: istio.io/istio.io + spec: + containers: + - command: + - ../test-infra/tools/automator/automator.sh + - --org=istio + - --repo=istio.io + - --token-path=/etc/github-token/oauth + - --cmd=make update_ref_docs + - --dry-run + image: gcr.io/istio-testing/build-tools:master-2020-04-28T21-48-12 + name: "" + resources: + limits: + cpu: "8" + memory: 24Gi + requests: + cpu: "5" + memory: 3Gi + securityContext: + privileged: true + volumeMounts: + - mountPath: /etc/github-token + name: github + readOnly: true + nodeSelector: + testing: test-pool + volumes: + - name: github + secret: + secretName: oauth-token diff --git a/prow/cluster/jobs/istio/istio/istio.istio.master.gen.yaml b/prow/cluster/jobs/istio/istio/istio.istio.master.gen.yaml index a9996893e3b..df5ffa8da10 100644 --- a/prow/cluster/jobs/istio/istio/istio.istio.master.gen.yaml +++ b/prow/cluster/jobs/istio/istio/istio.istio.master.gen.yaml @@ -1390,46 +1390,3 @@ presubmits: privileged: true nodeSelector: testing: test-pool - - always_run: true - annotations: - testgrid-dashboards: istio_istio - branches: - - ^master$ - decorate: true - extra_refs: - - base_ref: master - org: istio - path_alias: istio.io/test-infra - repo: test-infra - name: update-ref-docs-dry-run_istio - optional: true - path_alias: istio.io/istio - spec: - containers: - - command: - - ../test-infra/tools/automator/automator.sh - - --org=istio - - --repo=istio.io - - --token-path=/etc/github-token/oauth - - --cmd=make update_ref_docs - - --dry-run - image: gcr.io/istio-testing/build-tools:master-2020-04-28T21-48-12 - name: "" - resources: - limits: - memory: 24Gi - requests: - cpu: "5" - memory: 3Gi - securityContext: - privileged: true - volumeMounts: - - mountPath: /etc/github-token - name: github - readOnly: true - nodeSelector: - testing: test-pool - volumes: - - name: github - secret: - secretName: oauth-token diff --git a/prow/config/jobs/istio.io.yaml b/prow/config/jobs/istio.io.yaml index 4dc3ec24ba5..d2eb1a17805 100644 --- a/prow/config/jobs/istio.io.yaml +++ b/prow/config/jobs/istio.io.yaml @@ -21,6 +21,19 @@ jobs: command: [entrypoint, prow/integ-suite-kind.sh, test.kube.postsubmit] requirements: [kind, gcp] + - name: update-ref-docs-dry-run + type: presubmit + command: + - ../test-infra/tools/automator/automator.sh + - --org=istio + - --repo=istio.io + - --token-path=/etc/github-token/oauth + - --cmd=make update_ref_docs + - --dry-run + requirements: [github] + modifiers: [optional] + repos: [istio/test-infra] + - name: update-ref-docs type: periodic cron: "0 2 * * *" # every day at 02:00AM UTC diff --git a/prow/config/jobs/istio.yaml b/prow/config/jobs/istio.yaml index 0992d0f2f68..e9937f20609 100644 --- a/prow/config/jobs/istio.yaml +++ b/prow/config/jobs/istio.yaml @@ -245,19 +245,6 @@ jobs: type: presubmit command: [make, gen-check] - - name: update-ref-docs-dry-run - type: presubmit - command: - - ../test-infra/tools/automator/automator.sh - - --org=istio - - --repo=istio.io - - --token-path=/etc/github-token/oauth - - --cmd=make update_ref_docs - - --dry-run - requirements: [github] - modifiers: [optional] - repos: [istio/test-infra] - resources: default: requests: