Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

There is no way to provide "tolerations" to Kiali and tracing components #19480

Closed
nick4fake opened this issue Dec 9, 2019 · 6 comments · May be fixed by istio/installer#601
Closed

There is no way to provide "tolerations" to Kiali and tracing components #19480

nick4fake opened this issue Dec 9, 2019 · 6 comments · May be fixed by istio/installer#601

Comments

@nick4fake
Copy link

Bug description
There is no way to provide "tolerations" to Kiali component

Istio 1.4.1

I've tried the following:

Looks like currently there are only three options:

  • Deploying via Helm
  • Deploying Kiali as a separate chart (not sure if it is possible)
  • Adding additional tweak step to alter Kiali pod fields
@nick4fake nick4fake mentioned this issue Dec 9, 2019
Merged
@nick4fake
Copy link
Author

Relevant issue:
#19398

@nick4fake
Copy link
Author

Affects tracing too:
error: failed to generate manifest: input file failed validation with the following errors: unknown field "tolerations" in v1alpha1.TracingConfig

@nick4fake nick4fake changed the title There is no way to provide "tolerations" to Kiali component There is no way to provide "tolerations" to Kiali and tracing components Dec 9, 2019
@richardwxn
Copy link
Contributor

@nick4fake Please see my comment here: #19398 (comment). As I said, the reason why you feels like unvalidatedValues doesn't work is because there is even no tolerations defined in kiali and tracing deployment templates. E.g. https://github.com/istio/installer/blob/master/istio-telemetry/kiali/templates/deployment.yaml. I would add it to the templates and corresponding values part, should be available for 1.4.2

This was referenced Dec 10, 2019
Merged
Open
@nick4fake
Copy link
Author

@richardwxn Thank you a lot.

Regarding comments in istio/installer#601: this ticket is not only about "values" not fully covering legacy options. There don't seem to be any ways to specify these values through new API, as several components are not present there (Kiali and Jaeger being examples).

@nick4fake
Copy link
Author

@richardwxn
Another note:
error: failed to generate manifest: input file failed validation with the following errors: unknown field "defaultTolerations" in v1alpha1.GlobalConfig\

Looks like values.global.defaultTolerations is also missing.

@howardjohn
Copy link
Member

This is now provided via https://deploy-preview-7248--preliminary-istio.netlify.app/docs/setup/install/istioctl/#customize-kubernetes-settings. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

add tolerations richardwxn/istio-installer
4 participants
@howardjohn @nick4fake @richardwxn @istio-policy-bot