diff --git a/kubernetes/customresourcedefinitions.gen.yaml b/kubernetes/customresourcedefinitions.gen.yaml index c6753f4379..a403aa737f 100644 --- a/kubernetes/customresourcedefinitions.gen.yaml +++ b/kubernetes/customresourcedefinitions.gen.yaml @@ -197,12 +197,11 @@ spec: - UPGRADE type: string http1MaxPendingRequests: - description: Maximum number of pending HTTP requests - to a destination. format: int32 type: integer http2MaxRequests: - description: Maximum number of requests to a backend. + description: Maximum number of active requests to + a destination. format: int32 type: integer idleTimeout: @@ -448,13 +447,11 @@ spec: - UPGRADE type: string http1MaxPendingRequests: - description: Maximum number of pending HTTP - requests to a destination. format: int32 type: integer http2MaxRequests: - description: Maximum number of requests to - a backend. + description: Maximum number of active requests + to a destination. format: int32 type: integer idleTimeout: @@ -793,12 +790,10 @@ spec: - UPGRADE type: string http1MaxPendingRequests: - description: Maximum number of pending HTTP requests to - a destination. format: int32 type: integer http2MaxRequests: - description: Maximum number of requests to a backend. + description: Maximum number of active requests to a destination. format: int32 type: integer idleTimeout: @@ -1040,12 +1035,11 @@ spec: - UPGRADE type: string http1MaxPendingRequests: - description: Maximum number of pending HTTP requests - to a destination. format: int32 type: integer http2MaxRequests: - description: Maximum number of requests to a backend. + description: Maximum number of active requests to + a destination. format: int32 type: integer idleTimeout: @@ -1434,12 +1428,11 @@ spec: - UPGRADE type: string http1MaxPendingRequests: - description: Maximum number of pending HTTP requests - to a destination. format: int32 type: integer http2MaxRequests: - description: Maximum number of requests to a backend. + description: Maximum number of active requests to + a destination. format: int32 type: integer idleTimeout: @@ -1685,13 +1678,11 @@ spec: - UPGRADE type: string http1MaxPendingRequests: - description: Maximum number of pending HTTP - requests to a destination. format: int32 type: integer http2MaxRequests: - description: Maximum number of requests to - a backend. + description: Maximum number of active requests + to a destination. format: int32 type: integer idleTimeout: @@ -2030,12 +2021,10 @@ spec: - UPGRADE type: string http1MaxPendingRequests: - description: Maximum number of pending HTTP requests to - a destination. format: int32 type: integer http2MaxRequests: - description: Maximum number of requests to a backend. + description: Maximum number of active requests to a destination. format: int32 type: integer idleTimeout: @@ -2277,12 +2266,11 @@ spec: - UPGRADE type: string http1MaxPendingRequests: - description: Maximum number of pending HTTP requests - to a destination. format: int32 type: integer http2MaxRequests: - description: Maximum number of requests to a backend. + description: Maximum number of active requests to + a destination. format: int32 type: integer idleTimeout: diff --git a/networking/v1alpha3/destination_rule.gen.json b/networking/v1alpha3/destination_rule.gen.json index de1ee07028..ccb4f20658 100644 --- a/networking/v1alpha3/destination_rule.gen.json +++ b/networking/v1alpha3/destination_rule.gen.json @@ -74,12 +74,12 @@ "type": "object", "properties": { "http1MaxPendingRequests": { - "description": "Maximum number of pending HTTP requests to a destination. Default 2^32-1.", + "description": "Maximum number of requests that will be queued while waiting for a ready connection pool connection. Default 1024. Refer to https://www.envoyproxy.io/docs/envoy/latest/intro/arch_overview/upstream/circuit_breaking under which conditions a new connection is created for HTTP2. Please note that this is applicable to both HTTP/1.1 and HTTP2.", "type": "integer", "format": "int32" }, "http2MaxRequests": { - "description": "Maximum number of requests to a backend. Default 2^32-1.", + "description": "Maximum number of active requests to a destination. Default 1024. Please note that this is applicable to both HTTP/1.1 and HTTP2.", "type": "integer", "format": "int32" }, diff --git a/networking/v1alpha3/destination_rule.pb.go b/networking/v1alpha3/destination_rule.pb.go index 5fa45584b0..aa13c0ce1b 100644 --- a/networking/v1alpha3/destination_rule.pb.go +++ b/networking/v1alpha3/destination_rule.pb.go @@ -2219,9 +2219,14 @@ type ConnectionPoolSettings_HTTPSettings struct { sizeCache protoimpl.SizeCache unknownFields protoimpl.UnknownFields - // Maximum number of pending HTTP requests to a destination. Default 2^32-1. + // Maximum number of requests that will be queued while waiting for + // a ready connection pool connection. Default 1024. + // Refer to https://www.envoyproxy.io/docs/envoy/latest/intro/arch_overview/upstream/circuit_breaking + // under which conditions a new connection is created for HTTP2. + // Please note that this is applicable to both HTTP/1.1 and HTTP2. Http1MaxPendingRequests int32 `protobuf:"varint,1,opt,name=http1_max_pending_requests,json=http1MaxPendingRequests,proto3" json:"http1_max_pending_requests,omitempty"` - // Maximum number of requests to a backend. Default 2^32-1. + // Maximum number of active requests to a destination. Default 1024. + // Please note that this is applicable to both HTTP/1.1 and HTTP2. Http2MaxRequests int32 `protobuf:"varint,2,opt,name=http2_max_requests,json=http2MaxRequests,proto3" json:"http2_max_requests,omitempty"` // Maximum number of requests per connection to a backend. Setting this // parameter to 1 disables keep alive. Default 0, meaning "unlimited", diff --git a/networking/v1alpha3/destination_rule.pb.html b/networking/v1alpha3/destination_rule.pb.html index bb3decf5e6..bc52ee5568 100644 --- a/networking/v1alpha3/destination_rule.pb.html +++ b/networking/v1alpha3/destination_rule.pb.html @@ -1723,7 +1723,11 @@

ConnectionPoolSettings.HTTPSettings http1MaxPendingRequests int32 -

Maximum number of pending HTTP requests to a destination. Default 2^32-1.

+

Maximum number of requests that will be queued while waiting for +a ready connection pool connection. Default 1024. +Refer to https://www.envoyproxy.io/docs/envoy/latest/intro/arch_overview/upstream/circuit_breaking +under which conditions a new connection is created for HTTP2. +Please note that this is applicable to both HTTP/1.1 and HTTP2.

@@ -1734,7 +1738,8 @@

ConnectionPoolSettings.HTTPSettings http2MaxRequests int32 -

Maximum number of requests to a backend. Default 2^32-1.

+

Maximum number of active requests to a destination. Default 1024. +Please note that this is applicable to both HTTP/1.1 and HTTP2.

diff --git a/networking/v1alpha3/destination_rule.proto b/networking/v1alpha3/destination_rule.proto index b0a60447fe..68b7e4910d 100644 --- a/networking/v1alpha3/destination_rule.proto +++ b/networking/v1alpha3/destination_rule.proto @@ -709,10 +709,15 @@ message ConnectionPoolSettings { // Settings applicable to HTTP1.1/HTTP2/GRPC connections. message HTTPSettings { - // Maximum number of pending HTTP requests to a destination. Default 2^32-1. + // Maximum number of requests that will be queued while waiting for + // a ready connection pool connection. Default 1024. + // Refer to https://www.envoyproxy.io/docs/envoy/latest/intro/arch_overview/upstream/circuit_breaking + // under which conditions a new connection is created for HTTP2. + // Please note that this is applicable to both HTTP/1.1 and HTTP2. int32 http1_max_pending_requests = 1; - // Maximum number of requests to a backend. Default 2^32-1. + // Maximum number of active requests to a destination. Default 1024. + // Please note that this is applicable to both HTTP/1.1 and HTTP2. int32 http2_max_requests = 2; // Maximum number of requests per connection to a backend. Setting this diff --git a/networking/v1beta1/destination_rule.gen.json b/networking/v1beta1/destination_rule.gen.json index 0e74908a87..030400f974 100644 --- a/networking/v1beta1/destination_rule.gen.json +++ b/networking/v1beta1/destination_rule.gen.json @@ -74,12 +74,12 @@ "type": "object", "properties": { "http1MaxPendingRequests": { - "description": "Maximum number of pending HTTP requests to a destination. Default 2^32-1.", + "description": "Maximum number of requests that will be queued while waiting for a ready connection pool connection. Default 1024. Refer to https://www.envoyproxy.io/docs/envoy/latest/intro/arch_overview/upstream/circuit_breaking under which conditions a new connection is created for HTTP2. Please note that this is applicable to both HTTP/1.1 and HTTP2.", "type": "integer", "format": "int32" }, "http2MaxRequests": { - "description": "Maximum number of requests to a backend. Default 2^32-1.", + "description": "Maximum number of active requests to a destination. Default 1024. Please note that this is applicable to both HTTP/1.1 and HTTP2.", "type": "integer", "format": "int32" }, diff --git a/networking/v1beta1/destination_rule.pb.go b/networking/v1beta1/destination_rule.pb.go index d5099508b1..dd41540db5 100644 --- a/networking/v1beta1/destination_rule.pb.go +++ b/networking/v1beta1/destination_rule.pb.go @@ -2168,9 +2168,14 @@ type ConnectionPoolSettings_HTTPSettings struct { sizeCache protoimpl.SizeCache unknownFields protoimpl.UnknownFields - // Maximum number of pending HTTP requests to a destination. Default 2^32-1. + // Maximum number of requests that will be queued while waiting for + // a ready connection pool connection. Default 1024. + // Refer to https://www.envoyproxy.io/docs/envoy/latest/intro/arch_overview/upstream/circuit_breaking + // under which conditions a new connection is created for HTTP2. + // Please note that this is applicable to both HTTP/1.1 and HTTP2. Http1MaxPendingRequests int32 `protobuf:"varint,1,opt,name=http1_max_pending_requests,json=http1MaxPendingRequests,proto3" json:"http1_max_pending_requests,omitempty"` - // Maximum number of requests to a backend. Default 2^32-1. + // Maximum number of active requests to a destination. Default 1024. + // Please note that this is applicable to both HTTP/1.1 and HTTP2. Http2MaxRequests int32 `protobuf:"varint,2,opt,name=http2_max_requests,json=http2MaxRequests,proto3" json:"http2_max_requests,omitempty"` // Maximum number of requests per connection to a backend. Setting this // parameter to 1 disables keep alive. Default 0, meaning "unlimited", diff --git a/networking/v1beta1/destination_rule.proto b/networking/v1beta1/destination_rule.proto index 4bf4f22a05..1cd55a9aa3 100644 --- a/networking/v1beta1/destination_rule.proto +++ b/networking/v1beta1/destination_rule.proto @@ -658,10 +658,15 @@ message ConnectionPoolSettings { // Settings applicable to HTTP1.1/HTTP2/GRPC connections. message HTTPSettings { - // Maximum number of pending HTTP requests to a destination. Default 2^32-1. + // Maximum number of requests that will be queued while waiting for + // a ready connection pool connection. Default 1024. + // Refer to https://www.envoyproxy.io/docs/envoy/latest/intro/arch_overview/upstream/circuit_breaking + // under which conditions a new connection is created for HTTP2. + // Please note that this is applicable to both HTTP/1.1 and HTTP2. int32 http1_max_pending_requests = 1; - // Maximum number of requests to a backend. Default 2^32-1. + // Maximum number of active requests to a destination. Default 1024. + // Please note that this is applicable to both HTTP/1.1 and HTTP2. int32 http2_max_requests = 2; // Maximum number of requests per connection to a backend. Setting this