From c9b2abc14c837a40c8c314c164e082b9c45ca016 Mon Sep 17 00:00:00 2001 From: Mike Kolesnik Date: Sun, 15 Jun 2025 16:57:19 +0300 Subject: [PATCH] Skip cleanup if control plane tests fail Seems that this was missed in a recent refactor, so making sure the suite skips cleaning up when it failed and we want to keep the env. Use `ReportAfterSuite` which recieves a concentrated report and can tell if the suite has passed or failed. Signed-off-by: Mike Kolesnik --- tests/e2e/controlplane/control_plane_suite_test.go | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/tests/e2e/controlplane/control_plane_suite_test.go b/tests/e2e/controlplane/control_plane_suite_test.go index 7cc6ffc9d..fefc6fe1b 100644 --- a/tests/e2e/controlplane/control_plane_suite_test.go +++ b/tests/e2e/controlplane/control_plane_suite_test.go @@ -90,6 +90,10 @@ var _ = BeforeSuite(func(ctx SpecContext) { Success("Operator is deployed in the namespace and Running") }) -var _ = AfterSuite(func(ctx SpecContext) { +var _ = ReportAfterSuite("Condiotnal cleanup", func(ctx SpecContext, r Report) { + if !r.SuiteSucceeded && keepOnFailure { + return + } + clr.Cleanup(ctx) })