[release-1.30] Set DEPLOYMENT_NAME to csv name when OLM is true#1925
Merged
istio-testing merged 2 commits intoMay 19, 2026
Conversation
…sv when OLM is true (istio-ecosystem#1874) * test: Modify await_operator to dinamically get deployment name from csv when OLM is true If bundle name is different to sail operator and OLM is set to true in the test we got failures because await_operator never find a sail-operator deployment in the namespace Signed-off-by: Francisco Herrera <fjglira@gmail.com> * Get the deployment name from current .clusterserviceversion.yaml file in the manifest/bundle folder Changes from review Signed-off-by: Francisco Herrera <fjglira@gmail.com> --------- Signed-off-by: Francisco Herrera <fjglira@gmail.com>
This will avoid issues on the test while waiting for operator because will set DEPLOYMENT_NAME to the csv name used into fork test Signed-off-by: Francisco Herrera <fjglira@gmail.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## release-1.30 #1925 +/- ##
================================================
+ Coverage 80.52% 80.71% +0.19%
================================================
Files 51 51
Lines 2598 2598
================================================
+ Hits 2092 2097 +5
+ Misses 384 380 -4
+ Partials 122 121 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
MaxBab
approved these changes
May 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Manual cherry-pick for #1920.
The automatic cherry-pick of #1918 failed on
release-1.30because the prerequisite commit from #1874 had not been cherry-picked to this branch (it was cherry-picked to release-1.26 through release-1.29 but missed release-1.30).This PR cherry-picks both commits in order:
ca09f5fb— test: Modify await_operator to dynamically get deployment name from csv when OLM is true (test: Modify await_operator to dinamically get deployment name from csv when OLM is true #1874)9a08acd3— Set DEPLOYMENT_NAME to csv name when OLM is true (Set DEPLOYMENT_NAME to csv name when OLM is true #1918)What type of PR is this?
What this PR does / why we need it:
await_operatornow dynamically gets the deployment name from the bundle CSV when OLM is true, and also setsDEPLOYMENT_NAMEto that value. This avoids test failures when the bundle name differs fromsail-operator.Which issue(s) this PR fixes:
Fixes #1920
Related Issue/PR #1918 #1874