Skip to content

Apply source-maps in top-level process. #137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jamestalmage opened this issue Jan 12, 2016 · 5 comments
Closed

Apply source-maps in top-level process. #137

jamestalmage opened this issue Jan 12, 2016 · 5 comments

Comments

@jamestalmage
Copy link
Member

Right now we save source-maps to the cache, and apply them at the time of report creation. This prevents having to repeatedly extract the sourcemap, and did improve performance.

However, it has become a repeated failure point. This may be another example. Instead of waiting for report creation, I am starting to think that we should load up all the reports and apply the source-maps at the end of execution (similar to how we would if a --reporter is specified).

@bcoe
Copy link
Member

bcoe commented Jun 27, 2016

@jamestalmage more food for thought, it would be awesome to apply source-maps to stack traces.

@seanpoulter
Copy link

That's what I'm reading the issues for now @bcoe -- applying source-maps to stack traces. How can I help?

@bcoe
Copy link
Member

bcoe commented Mar 22, 2017

@seanpoulter sorry for the slow response, am at GitHub issue overload 😛

There has been some prior art with regards to supporting source-maps in stack traces:

#393 (thanks @kpdecker!)

It would be great to have another person try out the functionality; it would also be awesome to add a post on https://github.com/istanbuljs/istanbuljs.github.io.

@seanpoulter
Copy link

Understandably overwhelmed @bcoe.
I'll have a look over the coming week.

@bcoe
Copy link
Member

bcoe commented May 14, 2017

I've been making a few stability fixes recently around source-maps, and I think we're actually in a pretty healthy place using the cached approach -- closing this since we haven't seen activity in quite some time.

@bcoe bcoe closed this as completed May 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants