fix: discard more bad source map positions #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Restore code that was introduced in nyc 6.5.0 to handle bad source map locations. This fix was originally introduced into nyc's lib/source-map-cache.js, but when nyc transitioned to using istanbul-lib-source-maps this fix went astray. see original PR: istanbuljs/nyc#255
|
Thank you for submitting this pull request, however I do not see a valid CLA on file for you. Before we can merge this request please visit https://yahoocla.herokuapp.com/ and agree to the terms. Thanks! 😄 |
|
CLA is valid! |
|
@sc0ttyd seems like a reasonable safety to pull back in, mind adding a test? |
|
Sure, will do. |
|
Having looked at the code, literally nothing in transformer.js is tested (nor, for that matter, are the source-store.js, pathutils.js, or map-store.js files). Whilst I would actually be happy to take this task on in my spare time, I need this PR urgently for a fix for a problem that has shown up in my build pipeline. If you could merge this now, I'll be happy to add tests in my spare time for you? |
|
@sc0ttyd deal. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Restore code that was introduced in nyc 6.5.0 to handle bad source map locations. This fix was originally introduced into nyc's lib/source-map-cache.js, but when nyc transitioned to using istanbul-lib-source-maps this fix went astray.
see original PR: istanbuljs/nyc#255