Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BE] 이슈 카운트 쿼리 수정, 이미지 리사이징 추가 #180

Merged
merged 2 commits into from
Aug 21, 2023
Merged

[BE] 이슈 카운트 쿼리 수정, 이미지 리사이징 추가 #180

merged 2 commits into from
Aug 21, 2023

Conversation

HyowonSin
Copy link

@HyowonSin HyowonSin commented Aug 18, 2023 •
edited
Loading

Issues

What is this PR? 👓

  • 이슈 카운트 수정
  • 이미지 리사이징

Key changes 🔑

  • 이슈 카운트에서 is:open, is:closed 필터링이 적용되어도 상관 없이 open, closed 개수 카운트
  • 이미지 사이즈가 800 넘어갈 시엔 리사이징하여 저장

To reviewers 👋

  • 쿼리 맞나..
  • 사이즈 800 보다 큰 이미지 쓸 일 없을 것 같아 썸네일 처럼 따로 저장하지 않고 저 것만 저장했습니다.
  • 리사이징에 Marvin 이라는 라이브러리를 많이 쓰던데.. 시간이 없어서 써봤던 Thumbnailator 를 썼습니다..

@HyowonSin HyowonSin self-assigned this Aug 18, 2023
@HyowonSin HyowonSin added bug Something isn't working enhancement New feature or request back-end labels Aug 18, 2023
@HyowonSin HyowonSin added this to the [BE] Sprint #4 milestone Aug 18, 2023
This was linked to issues Aug 18, 2023
[BE] 이슈 카운트 수정 #178
Open
[BE] 이미지 리사이징 #179
Open
@HyowonSin HyowonSin changed the title Be/fix/issue count [BE] 이슈 카운트 쿼리 수정, 이미지 리사이징 추가 Aug 18, 2023
@23Yong 23Yong merged commit 8168313 into be-w4 Aug 21, 2023
1 check passed
@23Yong 23Yong deleted the be/fix/issue-count branch August 21, 2023 07:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tjdqls1200 tjdqls1200 Awaiting requested review from tjdqls1200

@23Yong 23Yong Awaiting requested review from 23Yong

@pie2457 pie2457 Awaiting requested review from pie2457

Assignees

@HyowonSin HyowonSin

Labels
back-end bug Something isn't working enhancement New feature or request
Projects
None yet
Milestone
[BE] Sprint #4
Development

Successfully merging this pull request may close these issues.

[BE] 이미지 리사이징 [BE] 이슈 카운트 수정
2 participants
@HyowonSin @23Yong