Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[refactor] Consider making encountered_fields a struct containing special fields + a hash map for all the rest #295

Open
rbalicki2 opened this issue Dec 26, 2024 · 0 comments
Open

[refactor] Consider making encountered_fields a struct containing special fields + a hash map for all the rest #295

rbalicki2 opened this issue Dec 26, 2024 · 0 comments

Comments

@rbalicki2
Copy link
Collaborator

rbalicki2 commented Dec 26, 2024 •
edited
Loading

  • this is speculative, we may try this and see it's not worth it! But I don't like that we do encountered_fields.get('__typename').expect(...).as_scalar_field().expect(...) when we know that that field exists and is a scalar!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@rbalicki2