Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(j-s): Upload Additional Files to Court #17152

Merged
merged 1 commit into from
Dec 5, 2024

Conversation

gudjong
Copy link
Member

@gudjong gudjong commented Dec 5, 2024

Upload Additional Files to Court

Bæta við nýjum file category-um til að senda á héraðsdóm (gögn sem eru send inn)

What

  • Uploads additional files from defenders and prosecutors in indictment cases to court.

Why

  • The court wants to receive these files.

Checklist:

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • Formatting passes locally with my changes
  • I have rebased against main before asking for a review

Summary by CodeRabbit

  • New Features

    • Enhanced case file management with new categories for prosecutor and defendant case files.
    • Improved messaging functionality for case files connected to court.
    • Updated interface to include additional properties for case updates.
  • Bug Fixes

    • Refined synchronization of police case numbers with case files.
    • Improved error handling for signature requests and confirmations.

@gudjong gudjong requested a review from a team as a code owner December 5, 2024 17:23
Copy link
Contributor

coderabbitai bot commented Dec 5, 2024

Warning

There were issues while running some tools. Please review the errors and either fix the tool’s configuration or disable the tool if it’s a critical failure.

🔧 eslint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

warning [email protected]: This version is no longer supported. Please see https://eslint.org/version-support for other options.
warning eslint > @humanwhocodes/[email protected]: Use @eslint/config-array instead
warning eslint > file-entry-cache > flat-cache > [email protected]: Rimraf versions prior to v4 are no longer supported
warning eslint > @humanwhocodes/config-array > @humanwhocodes/[email protected]: Use @eslint/object-schema instead
warning eslint > file-entry-cache > flat-cache > rimraf > [email protected]: Glob versions prior to v9 are no longer supported
warning eslint > file-entry-cache > flat-cache > rimraf > glob > [email protected]: This module is not supported, and leaks memory. Do not use it. Check out lru-cache if you want a good and tested way to coalesce async requests by a key value, which is much more comprehensive and powerful.
warning jest > jest-cli > jest-config > [email protected]: Glob versions prior to v9 are no longer supported
warning jest > @jest/core > jest-runtime > [email protected]: Glob versions prior to v9 are no longer supported
warning jest > @jest/core > @jest/reporters > [email protected]: Glob versions prior to v9 are no longer supported
warning jest > @jest/core > @jest/transform > babel-plugin-istanbul > test-exclude > [email protected]: Glob versions prior to v9 are no longer supported
warning storybook > @storybook/cli > puppeteer-core > [email protected]: Rimraf versions prior to v4 are no longer supported
warning storybook > @storybook/cli > puppeteer-core > rimraf > [email protected]: Glob versions prior to v9 are no longer supported
warning storybook > @storybook/cli > tempy > del > [email protected]: Rimraf versions prior to v4 are no longer supported
warning storybook > @storybook/cli > jscodeshift > temp > [email protected]: Rimraf versions prior to v4 are no longer supported
warning storybook > @storybook/cli > jscodeshift > temp > rimraf > [email protected]: Glob versions prior to v9 are no longer supported
warning storybook > @storybook/cli > jscodeshift > @babel/[email protected]: This proposal has been merged to the ECMAScript standard and thus this plugin is no longer maintained. Please use @babel/plugin-transform-class-properties instead.
warning storybook > @storybook/cli > jscodeshift > @babel/[email protected]: This proposal has been merged to the ECMAScript standard and thus this plugin is no longer maintained. Please use @babel/plugin-transform-nullish-coalescing-operator instead.
warning storybook > @storybook/cli > jscodeshift > @babel/[email protected]: This proposal has been merged to the ECMAScript standard and thus this plugin is no longer maintained. Please use @babel/plugin-transform-optional-chaining instead.
warning next-auth > [email protected]: The querystring API is considered Legacy. new code should use the URLSearchParams API instead.
warning next-auth > [email protected]: this version is no longer supported
warning next-auth > @next-auth/typeorm-legacy-adapter > typeorm > [email protected]: Glob versions prior to v9 are no longer supported
warning @nx/next > @nx/webpack > stylus > [email protected]: Glob versions prior to v9 are no longer supported
warning @nx/next > @nx/webpack > webpack-dev-server > [email protected]: Rimraf versions prior to v4 are no longer supported
warning @nx/next > @nx/webpack > fork-ts-checker-webpack-plugin > [email protected]: this will be v4
warning @nx/next > @nx/webpack > webpack-dev-server > webpack-dev-middleware > [email protected]: this will be v4
warning workspace-aggregator-042b0a55-8503-4557-bb17-e4c59ae621dd > [email protected]: This version is no longer supported. Please see https://eslint.org/version-support for other options.
warning "@nx/eslint > @nx/js > [email protected]" has unmet peer dependency "@types/node@".
warning "@nx/next > @babel/[email protected]" has unmet peer dependency "@babel/core@^7.0.0-0".
warning "styled-components > babel-plugin-styled-components > @babel/[email protected]" has unmet peer dependency "@babel/core@^7.0.0-0".
warning " > [email protected]" has unmet peer dependency "react-is@>= 16.8.0".
warning "@nx/react > [email protected]" has unmet peer dependency "webpack@^4.0.0 || ^5.0.0".
warning " > [email protected]" has unmet peer dependency "@types/node@
".
warning "@vanilla-extract/next-plugin > @vanilla-extract/[email protected]" has unmet peer dependency "webpack@^4.30.0 || ^5.20.2".
warning " > [email protected]" has incorrect peer dependency "react@^16.13.1 || ^17".
warning " > [email protected]" has incorrect peer dependency "react-dom@^16.13.1 || ^17".
warning "next-auth > @next-auth/[email protected]" has unmet peer dependency "@prisma/client@^2.16.1".
warning " > [email protected]" has incorrect peer dependency "next@^13.4".
warning "@nx/next > [email protected]" has unmet peer dependency "webpack@^5.1.0".

Walkthrough

The pull request introduces significant modifications to the CaseService and FileService classes within the judicial system application. Key enhancements include the addition of new case file categories, improved message handling for court cases, and refined synchronization of police case numbers with case files. The update method in CaseService has been enhanced for better state transition management, while error handling improvements provide clearer feedback on failures. Overall, these changes aim to streamline case file management and messaging processes.

Changes

File Path Change Summary
apps/judicial-system/backend/src/app/modules/case/case.service.ts - Enhanced CaseService with new case file categories and improved message handling for prosecutor and defendant files.
- Updated addMessagesForIndictmentCourtCaseConnectionToQueue and syncPoliceCaseNumbersAndCaseFiles methods for better synchronization and messaging.
- Improved error handling in requestCourtRecordSignature and getCourtRecordSignatureConfirmation.
- Modified UpdateCase interface to include new properties.
apps/judicial-system/backend/src/app/modules/file/file.service.ts - Updated FileService to handle new case file categories in getCourtDocumentFolder and refined messaging in createCaseFile.
- Removed previous handling for CaseFileCategory.COURT_RECORD.

Possibly related PRs

Suggested labels

automerge

Suggested reviewers

  • unakb

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Outside diff range and nitpick comments (1)
apps/judicial-system/backend/src/app/modules/case/case.service.ts (1)

778-787: Refactor to eliminate code duplication in caseFilesCategories assignment

The arrays assigned to caseFilesCategories in both branches of the conditional are almost identical, differing only in the inclusion of CaseFileCategory.INDICTMENT. Consider refactoring to define the common categories once and conditionally add CaseFileCategory.INDICTMENT when appropriate.

Apply this diff to refactor the code:

-const caseFilesCategories = isTrafficViolationCase(theCase)
-  ? [
-      CaseFileCategory.CRIMINAL_RECORD,
-      CaseFileCategory.COST_BREAKDOWN,
-      CaseFileCategory.CASE_FILE,
-      CaseFileCategory.PROSECUTOR_CASE_FILE,
-      CaseFileCategory.DEFENDANT_CASE_FILE,
-    ]
-  : [
-      CaseFileCategory.INDICTMENT,
-      CaseFileCategory.CRIMINAL_RECORD,
-      CaseFileCategory.COST_BREAKDOWN,
-      CaseFileCategory.CASE_FILE,
-      CaseFileCategory.PROSECUTOR_CASE_FILE,
-      CaseFileCategory.DEFENDANT_CASE_FILE,
-    ]
+const baseCaseFilesCategories = [
+  CaseFileCategory.CRIMINAL_RECORD,
+  CaseFileCategory.COST_BREAKDOWN,
+  CaseFileCategory.CASE_FILE,
+  CaseFileCategory.PROSECUTOR_CASE_FILE,
+  CaseFileCategory.DEFENDANT_CASE_FILE,
+]
+const caseFilesCategories = isTrafficViolationCase(theCase)
+  ? baseCaseFilesCategories
+  : [CaseFileCategory.INDICTMENT, ...baseCaseFilesCategories]
📜 Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between 4281d75 and 6fdd5b3.

📒 Files selected for processing (2)
  • apps/judicial-system/backend/src/app/modules/case/case.service.ts (1 hunks)
  • apps/judicial-system/backend/src/app/modules/file/file.service.ts (2 hunks)
🧰 Additional context used
📓 Path-based instructions (2)
apps/judicial-system/backend/src/app/modules/file/file.service.ts (1)

Pattern apps/**/*: "Confirm that the code adheres to the following:

  • NextJS best practices, including file structure, API routes, and static generation methods.
  • Efficient state management and server-side rendering techniques.
  • Optimal use of TypeScript for component and utility type safety."
apps/judicial-system/backend/src/app/modules/case/case.service.ts (1)

Pattern apps/**/*: "Confirm that the code adheres to the following:

  • NextJS best practices, including file structure, API routes, and static generation methods.
  • Efficient state management and server-side rendering techniques.
  • Optimal use of TypeScript for component and utility type safety."
🔇 Additional comments (2)
apps/judicial-system/backend/src/app/modules/file/file.service.ts (2)

155-156: Correct mapping of new case file categories

The new CaseFileCategory.PROSECUTOR_CASE_FILE and CaseFileCategory.DEFENDANT_CASE_FILE are appropriately mapped to CourtDocumentFolder.CASE_DOCUMENTS in the getCourtDocumentFolder method.


393-408: Correct handling of new case file categories in message queue

The code correctly adds logic to send messages to the queue when new PROSECUTOR_CASE_FILE and DEFENDANT_CASE_FILE are created for indictment cases.

Copy link

codecov bot commented Dec 5, 2024

Codecov Report

Attention: Patch coverage is 71.42857% with 2 lines in your changes missing coverage. Please review.

Project coverage is 35.75%. Comparing base (4281d75) to head (6fdd5b3).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...ystem/backend/src/app/modules/file/file.service.ts 71.42% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main   #17152   +/-   ##
=======================================
  Coverage   35.75%   35.75%           
=======================================
  Files        6925     6925           
  Lines      147605   147610    +5     
  Branches    42024    42030    +6     
=======================================
+ Hits        52772    52775    +3     
- Misses      94833    94835    +2     
Flag Coverage Δ
judicial-system-backend 55.77% <71.42%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...ystem/backend/src/app/modules/case/case.service.ts 90.34% <ø> (ø)
...ystem/backend/src/app/modules/file/file.service.ts 71.17% <71.42%> (-0.26%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4281d75...6fdd5b3. Read the comment docs.

@datadog-island-is
Copy link

Datadog Report

Branch report: j-s/additional-files-to-court
Commit report: 0b32ef2
Test service: judicial-system-backend

✅ 0 Failed, 21278 Passed, 0 Skipped, 22m 20.6s Total Time
➡️ Test Sessions change in coverage: 1 no change

@oddsson oddsson added the automerge Merge this PR as soon as all checks pass label Dec 5, 2024
@kodiakhq kodiakhq bot merged commit 2421d10 into main Dec 5, 2024
50 checks passed
@kodiakhq kodiakhq bot deleted the j-s/additional-files-to-court branch December 5, 2024 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Merge this PR as soon as all checks pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants