feat(j-s): Upload Confirmed Court Record to Court

[gudjong]

Upload Confirmed Court Record to Court

Skila staðfestri þingbók í Auði

What

• Uploads confirmed court record to court when indictment cate is completed.

Why

• The court wants the confirmed court record stored in its system.

Checklist:

• I have performed a self-review of my own code
• I have made corresponding changes to the documentation
• My changes generate no new warnings
• I have added tests that prove my fix is effective or that my feature works
• Formatting passes locally with my changes
• I have rebased against main before asking for a review

Summary by CodeRabbit

Summary by CodeRabbit

• New Features
  • Enhanced message handling for completed indictment cases, allowing a broader range of case file categories to trigger notifications.
  • Updated criteria for sending messages related to completed cases, improving user notifications regarding case status.

[coderabbitai]

Walkthrough

The changes in this pull request focus on modifying the filtering logic within the addMessagesForCompletedIndictmentCaseToQueue method of the CaseService class. The update allows for multiple case file categories to be considered when sending messages for completed indictment cases. The method now checks if caseFile.category is included in an array containing both CaseFileCategory.COURT_RECORD and CaseFileCategory.RULING, enhancing the criteria for triggering message sending.

Changes

File Path	Change Summary
apps/judicial-system/backend/src/app/modules/case/case.service.ts	Updated filtering logic in addMessagesForCompletedIndictmentCaseToQueue to include CaseFileCategory.COURT_RECORD alongside CaseFileCategory.RULING.

Possibly related PRs

• feat(j-s): Completed indictment overview #14780: This PR introduces new values related to case file categories, which may interact with the updated filtering logic in the main PR that broadens the categories considered for message sending.
• chore(j-s): Criminal record update visible in in indictments case lists #15099: This PR adds functionality to filter case files based on CRIMINAL_RECORD_UPDATE, which is relevant to the changes made in the main PR regarding case file category filtering.
• chore(j-s): Indictment Case Arrignment Date #16156: This PR modifies the CaseService class, which includes the same method (addMessagesForCompletedIndictmentCaseToQueue) that is altered in the main PR, indicating a direct relationship in the handling of case messages.
• feat(j-s): Deliver Confirmed Indictment Ruling to Court #17104: This PR also modifies the addMessagesForCompletedIndictmentCaseToQueue method, refining the logic for message construction, which is closely related to the changes made in the main PR.

Suggested reviewers

• unakb
• oddsson

---

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between 2799798 and 167de6b.

📒 Files selected for processing (1)

• apps/judicial-system/backend/src/app/modules/case/case.service.ts (1 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

• apps/judicial-system/backend/src/app/modules/case/case.service.ts

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[datadog-island-is]

Datadog Report

All test runs e7937f3 🔗

✅ 2 Total Test Services: 0 Failed, 2 Passed
➡️ Test Sessions change in coverage: 2 no change

Test Services

Service Name	Failed	Known Flaky	New Flaky	Passed	Skipped	Total Time	Code Coverage Change	Test Service View
judicial-system-backend	0	0	0	21234	0	22m 26.52s	1 no change	Link
judicial-system-web	0	0	0	332	0	1m 15.5s	1 no change	Link

[codecov]

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 35.74%. Comparing base (500eef8) to head (167de6b).
Report is 1 commits behind head on main.

Files with missing lines	Patch %	Lines
...ystem/backend/src/app/modules/case/case.service.ts	50.00%	1 Missing ⚠️

Additional details and impacted files

@@           Coverage Diff           @@
##             main   #17150   +/-   ##
=======================================
  Coverage   35.74%   35.74%           
=======================================
  Files        6925     6925           
  Lines      147648   147645    -3     
  Branches    42050    42048    -2     
=======================================
  Hits        52779    52779           
+ Misses      94869    94866    -3     

Flag	Coverage Δ
judicial-system-backend	55.72% <50.00%> (+<0.01%)	⬆️
judicial-system-web	27.92% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
...ystem/backend/src/app/modules/case/case.service.ts	90.51% <50.00%> (+0.16%)	⬆️

... and 1 file with indirect coverage changes

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 500eef8...167de6b. Read the comment docs.