feat(j-s): Deliver Confirmed Indictment Ruling to Court

[gudjong]

Deliver Confirmed Indictment Ruling to Court

Skila staðfestum dómi í Auði

What

• Delivers confirmed indictment ruling to the district court.

Why

• Although the ruling is uploaded by the court, the court wants to get it back with a confirmation.

Checklist:

• I have performed a self-review of my own code
• I have made corresponding changes to the documentation
• My changes generate no new warnings
• I have added tests that prove my fix is effective or that my feature works
• Formatting passes locally with my changes
• I have rebased against main before asking for a review

Summary by CodeRabbit

• New Features

  • Enhanced notification messages for completed indictment cases, ensuring relevance by filtering case files.
  • Added specific messaging for cases originating from LOKE.

• Bug Fixes

  • Improved clarity and relevance of messages sent regarding case files.

[coderabbitai]

Walkthrough

The pull request modifies the addMessagesForCompletedIndictmentCaseToQueue method in the CaseService class. It refines the logic for constructing the messages array by filtering caseFiles based on their state, key validity, and category. Additionally, it appends a specific message if the case originates from LOKE. The overall control flow remains unchanged, but the message construction process is more focused on relevant case files.

Changes

File Path	Change Summary
apps/judicial-system/backend/src/app/modules/case/case.service.ts	Modified addMessagesForCompletedIndictmentCaseToQueue method to filter case files and refine message construction.

Possibly related PRs

• chore(j-s): Indictment Case Arrignment Date #16156: This PR modifies the addMessagesForNewCourtDateToQueue method in the CaseService class, which is directly related to the addMessagesForCompletedIndictmentCaseToQueue method modified in the main PR, as both involve constructing messages for court-related cases.
• feat(j-s): Completed indictment overview #14780: This PR introduces a "completed indictment overview" page that likely interacts with the logic for completed cases, which is relevant to the changes made in the main PR regarding message handling for completed indictments.
• fix(j-s): Indictment Post Processing #15077: This PR updates the Completed.tsx file to conditionally render a section based on the indictmentRulingDecision, which is relevant to the logic of filtering messages in the main PR that also considers the indictmentRulingDecision.
• feat(j-s): Case Files Added Notification #16452: This PR adds notification functionality for case file updates, which may relate to the message construction logic in the main PR, as both involve notifying relevant parties about case developments.

Suggested labels

automerge

Suggested reviewers

• unakb
• oddsson

---

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between 0f00701 and 15664df.

📒 Files selected for processing (1)

• apps/judicial-system/backend/src/app/modules/case/case.service.ts (1 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

• apps/judicial-system/backend/src/app/modules/case/case.service.ts

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[datadog-island-is]

Datadog Report

Branch report: j-s/confirmed-ruling-to-court
Commit report: 1ad0e15
Test service: judicial-system-backend

✅ 0 Failed, 21259 Passed, 0 Skipped, 23m 24.51s Total Time
➡️ Test Sessions change in coverage: 1 no change

[codecov]

Codecov Report

Attention: Patch coverage is 66.66667% with 3 lines in your changes missing coverage. Please review.

Project coverage is 35.68%. Comparing base (0d59ea6) to head (dc320c2).
Report is 1 commits behind head on main.

Files with missing lines	Patch %	Lines
...ystem/backend/src/app/modules/case/case.service.ts	66.66%	3 Missing ⚠️

Additional details and impacted files

@@           Coverage Diff           @@
##             main   #17104   +/-   ##
=======================================
  Coverage   35.68%   35.68%           
=======================================
  Files        6946     6946           
  Lines      147393   147401    +8     
  Branches    41897    41904    +7     
=======================================
+ Hits        52595    52600    +5     
- Misses      94798    94801    +3     

Flag	Coverage Δ
judicial-system-backend	55.66% <66.66%> (+<0.01%)	⬆️
web	2.44% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
...ystem/backend/src/app/modules/case/case.service.ts	90.34% <66.66%> (-0.42%)	⬇️

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0d59ea6...dc320c2. Read the comment docs.