fix(work-machines): last inspection date fix

[thorkellmani]

What

• Display a string if a machine has no inspection date

Why

• Requested

Screenshots / Gifs

Attach Screenshots / Gifs to help reviewers understand the scope of the pull request

Checklist:

• I have performed a self-review of my own code
• I have made corresponding changes to the documentation
• My changes generate no new warnings
• I have added tests that prove my fix is effective or that my feature works
• Formatting passes locally with my changes
• I have rebased against main before asking for a review

Summary by CodeRabbit

• New Features
  • Added localization support for inspection absence with a new message: 'Óskoðuð'.
• Enhancements
  • Improved validation for the last inspection date to ensure only valid dates are displayed.
  • Enhanced user feedback by displaying a message when no inspection date is available.
  • Streamlined code in the WorkMachinesOverview component for better readability and maintainability.
• Bug Fixes
  • Ensured that only defined work machine objects are included in the output, improving data integrity.

[coderabbitai]

Walkthrough

The changes involve enhancements to the handling of the dateLastInspection property in the WorkMachinesService class, ensuring only valid dates are processed. A new message for localization regarding the absence of inspections is added. The WorkMachinesDetail component now conditionally renders the last inspection date, providing a fallback message if unavailable. Lastly, the WorkMachinesOverview component simplifies the logic for displaying the registration number and last inspection date by removing the generateCardText function in favor of inline implementation.

Changes

Files	Change Summary
libs/api/domains/work-machines/src/lib/workMachines.service.ts	Enhanced handling of dateLastInspection with validation and filtering of undefined values.
libs/service-portal/assets/src/lib/messages.ts	Added a new message sp.work-machines:no-inspection for localization regarding no inspections.
libs/service-portal/assets/src/screens/WorkMachinesDetail/WorkMachinesDetail.tsx	Implemented conditional rendering for last inspection date with a fallback message.
libs/service-portal/assets/src/screens/WorkMachinesOverview/WorkMachinesOverview.tsx	Removed generateCardText function, replaced with inline logic for displaying inspection date.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  -- I pushed a fix in commit <commit_id>, please review it.
  -- Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  -- @coderabbitai generate unit testing code for this file.
  -- @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  -- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  -- @coderabbitai read src/utils.ts and generate unit testing code.
  -- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  -- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[datadog-island-is]

Datadog Report

Branch report: fix/work-machines-inspection-date-fix
Commit report: 1a7babb
Test service: api

✅ 0 Failed, 4 Passed, 0 Skipped, 3.03s Total Time
➡️ Test Sessions change in coverage: 1 no change

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 36.62%. Comparing base (4e76ba9) to head (f251735).
Report is 1 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #16040      +/-   ##
==========================================
- Coverage   36.65%   36.62%   -0.03%     
==========================================
  Files        6750     6749       -1     
  Lines      138925   138842      -83     
  Branches    39472    39453      -19     
==========================================
- Hits        50926    50855      -71     
+ Misses      87999    87987      -12     

Flag	Coverage Δ
api	3.39% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 14 files with indirect coverage changes

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4e76ba9...f251735. Read the comment docs.

[github-actions]

Affected services are: api,service-portal,system-e2e,
Feature deployment of your services will begin shortly. Your feature will be accessible here:
https://fixwork-machines-inspection-date-fix-api-catalogue.dev01.devland.is/api
https://fixwork-machines-inspection-date-fix-beta.dev01.devland.is/
https://fixwork-machines-inspection-date-fix-beta.dev01.devland.is/api
https://fixwork-machines-inspection-date-fix-beta.dev01.devland.is/minarsidur
https://fixwork-machines-inspection-date-fix-beta.dev01.devland.is/samradsgatt

Deployed services: service-portal,api,consultation-portal,web.
Excluded services: ``