Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(applications): Minor translation fixes #15929

Merged
merged 2 commits into from
Sep 10, 2024
Merged

Conversation

norda-gunni
Copy link
Member

@norda-gunni norda-gunni commented Sep 10, 2024

...

Attach a link to issue if relevant

What

Specify what you're trying to achieve

Why

Specify why you need to achieve this

Screenshots / Gifs

Attach Screenshots / Gifs to help reviewers understand the scope of the pull request

Checklist:

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • Formatting passes locally with my changes
  • I have rebased against main before asking for a review

Summary by CodeRabbit

  • New Features

    • Enhanced localization support for the Date of Accident component, allowing for dynamically formatted labels and placeholders based on user language settings.
    • Improved flexibility in the Accident Notification Form by sourcing section titles from dynamic references, facilitating better localization and maintainability.
  • Bug Fixes

    • Resolved hardcoded titles in the Accident Notification Form sections to ensure they reflect dynamic, localized values.

Copy link
Contributor

coderabbitai bot commented Sep 10, 2024

Walkthrough

The changes involve enhancements to localization across multiple components within the accident notification module. The DateOfAccident component now utilizes the formatMessage method for dynamic message formatting, improving its internationalization capabilities. Additionally, the locationSubSection and externalDataSection components have transitioned from hardcoded titles to dynamic references sourced from external localization files, allowing for greater flexibility in managing UI text.

Changes

Files Change Summary
libs/application/templates/accident-notification/src/fields/DateOfAccident/index.tsx Added dynamic message formatting using formatMessage for the date label and placeholder in the DateOfAccident component.
libs/application/templates/accident-notification/src/forms/AccidentNotificationForm/aboutTheAccidentSection/locationSubSection.ts Modified title in locationSubSection from a hardcoded string to a dynamic reference accidentLocation.general.listTitle.
libs/application/templates/accident-notification/src/forms/AccidentNotificationForm/externalDataSection/index.ts Updated title in externalDataSection from a hardcoded string to a dynamic value sourced from externalData.agreementDescription.listTitle.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

codecov bot commented Sep 10, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 36.81%. Comparing base (5337032) to head (35cf7e4).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...t-notification/src/fields/DateOfAccident/index.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main   #15929   +/-   ##
=======================================
  Coverage   36.81%   36.81%           
=======================================
  Files        6691     6691           
  Lines      137093   137093           
  Branches    38968    38968           
=======================================
  Hits        50464    50464           
  Misses      86629    86629           
Flag Coverage Δ
api 3.39% <ø> (ø)
application-system-api 41.67% <ø> (ø)
application-template-api-modules 23.54% <ø> (+0.01%) ⬆️
application-templates-accident-notification 19.83% <0.00%> (ø)
application-ui-shell 21.08% <ø> (ø)
judicial-system-web 28.71% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...Form/aboutTheAccidentSection/locationSubSection.ts 0.00% <ø> (ø)
...identNotificationForm/externalDataSection/index.ts 0.00% <ø> (ø)
...-notification/src/lib/messages/accidentLocation.ts 100.00% <ø> (ø)
...dent-notification/src/lib/messages/externalData.ts 100.00% <ø> (ø)
...t-notification/src/fields/DateOfAccident/index.tsx 0.00% <0.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5337032...35cf7e4. Read the comment docs.

@norda-gunni norda-gunni changed the title Minor translation fixes fix(applications): Minor translation fixes Sep 10, 2024
@datadog-island-is
Copy link

Datadog Report

All test runs a2b23c5 🔗

5 Total Test Services: 0 Failed, 5 Passed
➡️ Test Sessions change in coverage: 8 no change

Test Services
Service Name Failed Known Flaky New Flaky Passed Skipped Total Time Code Coverage Change Test Service View
api 0 0 0 4 0 3.24s 1 no change Link
application-system-api 0 0 0 111 2 4m 4.95s 1 no change Link
application-template-api-modules 0 0 0 109 0 1m 59.56s 1 no change Link
application-templates-accident-notification 0 0 0 98 0 20.98s 1 no change Link
application-ui-shell 0 0 0 74 0 38.94s 1 no change Link

@norda-gunni norda-gunni marked this pull request as ready for review September 10, 2024 09:28
@norda-gunni norda-gunni requested a review from a team as a code owner September 10, 2024 09:28
@norda-gunni norda-gunni added the automerge Merge this PR as soon as all checks pass label Sep 10, 2024
@kodiakhq kodiakhq bot merged commit 6f98772 into main Sep 10, 2024
39 checks passed
@kodiakhq kodiakhq bot deleted the fix/minor-translation-fixes branch September 10, 2024 10:22
jonnigs pushed a commit that referenced this pull request Sep 12, 2024
Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Merge this PR as soon as all checks pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants