Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(j-s): Completed indictment overview #14780

Merged
merged 68 commits into from
May 15, 2024
Merged

feat(j-s): Completed indictment overview #14780

merged 68 commits into from
May 15, 2024

Conversation

oddsson
Copy link
Member

@oddsson oddsson commented May 13, 2024

Completed indictment overview

Asana

What

Added a "completed indictment overview" page, i.e. the page displayed after a judge completes an indictment. This page contains an info card, a list of all case files, a input file upload to upload updates to a criminal record and a "service requirement" section if the case ends in a ruling.

Why

Just another step towards our goal of implementing the new S-cases flow.

Screenshots / Gifs

image

Checklist:

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • Formatting passes locally with my changes
  • I have rebased against main before asking for a review

Summary by CodeRabbit

  • New Features

    • Introduced a new case file category: "Criminal Record Update."
    • Added a "Completed" component for handling completed indictments, including file uploads and defendant updates.
  • Enhancements

    • Added a new title for court indictments indicating completed cases.
    • Improved filtering of case files to include the new "Criminal Record Update" category.
  • Bug Fixes

    • Simplified logic for determining closed cases in the overview, directly using the CaseState enum.
  • Documentation

    • Updated internationalized messages for completed indictments.
  • Refactor

    • Removed unnecessary service requirement strings from the overview.
    • Updated navigation logic in the summary component to use dynamic URLs.

oddsson and others added 30 commits May 2, 2024 22:29
@oddsson oddsson added automerge Merge this PR as soon as all checks pass skip-generated-cache labels May 14, 2024
@oddsson oddsson requested a review from a team as a code owner May 15, 2024 09:48
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review Details

Configuration used: .coderabbit.yaml
Review profile: CHILL

Commits Files that changed from the base of the PR and between 0a22587 and b554612.
Files selected for processing (1)
  • scripts/_hash-generated-files.sh (1 hunks)
Files skipped from review due to trivial changes (1)
  • scripts/_hash-generated-files.sh

Copy link
Member

@lodmfjord lodmfjord left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kodiakhq kodiakhq bot merged commit 3e51015 into main May 15, 2024
38 checks passed
@kodiakhq kodiakhq bot deleted the j-s/ind-overview branch May 15, 2024 13:38
jonnigs pushed a commit that referenced this pull request May 17, 2024
* Implement frontend

* Checkpoint

* Checkpoint

* Checkpoint

* Cleanup

* Update apps/judicial-system/backend/src/app/modules/case/models/case.model.ts

* Make CourtArrangements more generic

* Checkpoint

* Add CaseFiles to summary screen

* Checkpoint

* Remove ruling decision from caseList

* Refactor

* Fixes auto dates in db

* Error handling

* Rewrites case transitions

* Add ruling case file to summary page

* Add modal to summary page and transition case

* Destroy everything regarding postponment when completing cases

* Use Table component for appealed cases

* Merge

* Added a Completed screen

* Routing

* Add CaseFileCategory CRIMINAL_RECORD_UPDATE

* Remove upload to court functionality

* Checkpoint

* Add CRIMINAL_RECORD_UPDATE file upload

* Fix validation

* Add title

* Cleanup

* Revert change

* Revert change

* Revert change

* Revert change

* Revert change

* Revert change

* Cleanup

* Cleanup

* Cleanup

* fix: force generate file

---------

Co-authored-by: Guðjón Guðjónsson <[email protected]>
Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
Co-authored-by: lommi <[email protected]>
jonnigs pushed a commit that referenced this pull request May 17, 2024
* Implement frontend

* Checkpoint

* Checkpoint

* Checkpoint

* Cleanup

* Update apps/judicial-system/backend/src/app/modules/case/models/case.model.ts

* Make CourtArrangements more generic

* Checkpoint

* Add CaseFiles to summary screen

* Checkpoint

* Remove ruling decision from caseList

* Refactor

* Fixes auto dates in db

* Error handling

* Rewrites case transitions

* Add ruling case file to summary page

* Add modal to summary page and transition case

* Destroy everything regarding postponment when completing cases

* Use Table component for appealed cases

* Merge

* Added a Completed screen

* Routing

* Add CaseFileCategory CRIMINAL_RECORD_UPDATE

* Remove upload to court functionality

* Checkpoint

* Add CRIMINAL_RECORD_UPDATE file upload

* Fix validation

* Add title

* Cleanup

* Revert change

* Revert change

* Revert change

* Revert change

* Revert change

* Revert change

* Cleanup

* Cleanup

* Cleanup

* fix: force generate file

---------

Co-authored-by: Guðjón Guðjónsson <[email protected]>
Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
Co-authored-by: lommi <[email protected]>
Ballioli pushed a commit that referenced this pull request May 17, 2024
* Implement frontend

* Checkpoint

* Checkpoint

* Checkpoint

* Cleanup

* Update apps/judicial-system/backend/src/app/modules/case/models/case.model.ts

* Make CourtArrangements more generic

* Checkpoint

* Add CaseFiles to summary screen

* Checkpoint

* Remove ruling decision from caseList

* Refactor

* Fixes auto dates in db

* Error handling

* Rewrites case transitions

* Add ruling case file to summary page

* Add modal to summary page and transition case

* Destroy everything regarding postponment when completing cases

* Use Table component for appealed cases

* Merge

* Added a Completed screen

* Routing

* Add CaseFileCategory CRIMINAL_RECORD_UPDATE

* Remove upload to court functionality

* Checkpoint

* Add CRIMINAL_RECORD_UPDATE file upload

* Fix validation

* Add title

* Cleanup

* Revert change

* Revert change

* Revert change

* Revert change

* Revert change

* Revert change

* Cleanup

* Cleanup

* Cleanup

* fix: force generate file

---------

Co-authored-by: Guðjón Guðjónsson <[email protected]>
Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
Co-authored-by: lommi <[email protected]>
@coderabbitai coderabbitai bot mentioned this pull request Oct 4, 2024
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Merge this PR as soon as all checks pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants