-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(j-s): Completed indictment overview #14780
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s into j-s/complete-decision
…s into j-s/complete-indictment-page
…nto j-s/complete-decision
…s into j-s/complete-indictment-page
oddsson
added
automerge
Merge this PR as soon as all checks pass
skip-generated-cache
labels
May 14, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review Details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Files selected for processing (1)
- scripts/_hash-generated-files.sh (1 hunks)
Files skipped from review due to trivial changes (1)
- scripts/_hash-generated-files.sh
lodmfjord
approved these changes
May 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
jonnigs
pushed a commit
that referenced
this pull request
May 17, 2024
* Implement frontend * Checkpoint * Checkpoint * Checkpoint * Cleanup * Update apps/judicial-system/backend/src/app/modules/case/models/case.model.ts * Make CourtArrangements more generic * Checkpoint * Add CaseFiles to summary screen * Checkpoint * Remove ruling decision from caseList * Refactor * Fixes auto dates in db * Error handling * Rewrites case transitions * Add ruling case file to summary page * Add modal to summary page and transition case * Destroy everything regarding postponment when completing cases * Use Table component for appealed cases * Merge * Added a Completed screen * Routing * Add CaseFileCategory CRIMINAL_RECORD_UPDATE * Remove upload to court functionality * Checkpoint * Add CRIMINAL_RECORD_UPDATE file upload * Fix validation * Add title * Cleanup * Revert change * Revert change * Revert change * Revert change * Revert change * Revert change * Cleanup * Cleanup * Cleanup * fix: force generate file --------- Co-authored-by: Guðjón Guðjónsson <[email protected]> Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com> Co-authored-by: lommi <[email protected]>
jonnigs
pushed a commit
that referenced
this pull request
May 17, 2024
* Implement frontend * Checkpoint * Checkpoint * Checkpoint * Cleanup * Update apps/judicial-system/backend/src/app/modules/case/models/case.model.ts * Make CourtArrangements more generic * Checkpoint * Add CaseFiles to summary screen * Checkpoint * Remove ruling decision from caseList * Refactor * Fixes auto dates in db * Error handling * Rewrites case transitions * Add ruling case file to summary page * Add modal to summary page and transition case * Destroy everything regarding postponment when completing cases * Use Table component for appealed cases * Merge * Added a Completed screen * Routing * Add CaseFileCategory CRIMINAL_RECORD_UPDATE * Remove upload to court functionality * Checkpoint * Add CRIMINAL_RECORD_UPDATE file upload * Fix validation * Add title * Cleanup * Revert change * Revert change * Revert change * Revert change * Revert change * Revert change * Cleanup * Cleanup * Cleanup * fix: force generate file --------- Co-authored-by: Guðjón Guðjónsson <[email protected]> Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com> Co-authored-by: lommi <[email protected]>
Ballioli
pushed a commit
that referenced
this pull request
May 17, 2024
* Implement frontend * Checkpoint * Checkpoint * Checkpoint * Cleanup * Update apps/judicial-system/backend/src/app/modules/case/models/case.model.ts * Make CourtArrangements more generic * Checkpoint * Add CaseFiles to summary screen * Checkpoint * Remove ruling decision from caseList * Refactor * Fixes auto dates in db * Error handling * Rewrites case transitions * Add ruling case file to summary page * Add modal to summary page and transition case * Destroy everything regarding postponment when completing cases * Use Table component for appealed cases * Merge * Added a Completed screen * Routing * Add CaseFileCategory CRIMINAL_RECORD_UPDATE * Remove upload to court functionality * Checkpoint * Add CRIMINAL_RECORD_UPDATE file upload * Fix validation * Add title * Cleanup * Revert change * Revert change * Revert change * Revert change * Revert change * Revert change * Cleanup * Cleanup * Cleanup * fix: force generate file --------- Co-authored-by: Guðjón Guðjónsson <[email protected]> Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com> Co-authored-by: lommi <[email protected]>
6 tasks
6 tasks
This was referenced Oct 18, 2024
This was referenced Oct 31, 2024
This was referenced Nov 19, 2024
This was referenced Nov 27, 2024
This was referenced Dec 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Completed indictment overview
Asana
What
Added a "completed indictment overview" page, i.e. the page displayed after a judge completes an indictment. This page contains an info card, a list of all case files, a input file upload to upload updates to a criminal record and a "service requirement" section if the case ends in a ruling.
Why
Just another step towards our goal of implementing the new S-cases flow.
Screenshots / Gifs
Checklist:
Summary by CodeRabbit
New Features
Enhancements
Bug Fixes
CaseState
enum.Documentation
Refactor