Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove postinstall script #14352

Merged
merged 6 commits into from
Apr 10, 2024
Merged
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion apps/system-e2e/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -193,7 +193,7 @@ You will need a few things to set up your test so it can run with mountebank.

Now that you are set up. You need to run a couple of commands.

- In your terminal run `yarn infra render-local-env --service=service-portal --service=api` .
- In your terminal run `yarn cli render-local-env --service=service-portal --service=api` .
busla marked this conversation as resolved.
Show resolved Hide resolved
busla marked this conversation as resolved.
Show resolved Hide resolved
- This would show you commands how to start the mocking for `service-portal` and `api`. Replace with the services you want to test.
- In the output you will see a docker output it will look something like this: `docker run -it --rm -p ...` copy that line and run in a new terminal window. Now your Mountebank impostor should be running.
- Now start your services, but make sure your services ports have been replaced by the ports provided by Mountebank. In this examples case that would be `XROAD_BASE_PATH=http://localhost:9388 yarn start api`
Expand Down
6 changes: 3 additions & 3 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -55,10 +55,10 @@
"openapi-generator": "openapi-generator generate -g typescript-fetch --additional-properties=typescriptThreePlus=true",
"codegen": "node scripts/codegen.js",
"schemas": "echo 'The `schemas` script is deprecated. Please run `yarn codegen` instead.' && node scripts/codegen.js",
"postinstall": "node -e 'process.exit(process.env.CI || process.env.SKIP_POSTINSTALL ? 0 : 1);' || node ./scripts/postinstall.js",
"check-tags": "yarn ts scripts/check-tags.ts",
"charts": "cd ./infra && yarn install > /dev/null && yarn charts",
"infra": "cd ./infra && yarn install > /dev/null && yarn cli",
"charts": "yarn charts",
busla marked this conversation as resolved.
Show resolved Hide resolved
busla marked this conversation as resolved.
Show resolved Hide resolved
"infra": "yarn ./infra install",
busla marked this conversation as resolved.
Show resolved Hide resolved
"cli": "yarn ./infra cli",
"run-proxies": "./scripts/run-proxies.sh",
"proxies": "yarn run-proxies",
"hmr-benchmark": "node -r esbuild-register scripts/hmr-benchmark.ts"
Expand Down
25 changes: 0 additions & 25 deletions scripts/postinstall.js

This file was deleted.

Loading