chore: remove postinstall script #14352
Conversation
WalkthroughThe recent update involves refining the setup for test mocking services and reorganizing scripts within the project to streamline the development process. Notably, the test mocking setup command has been updated, and significant changes have been made to scripts in Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
Review Status
Configuration used: .coderabbit.yaml
Files selected for processing (2)
- apps/system-e2e/README.md (1 hunks)
- package.json (1 hunks)
Additional Context Used
Path-based Instructions (1)
apps/system-e2e/README.md (1)
Pattern
apps/**/*: "Confirm that the code adheres to the following:
- NextJS best practices, including file structure, API routes, and static generation methods.
- Efficient state management and server-side rendering techniques.
- Optimal use of TypeScript for component and utility type safety."
Additional comments not posted (3)
package.json (3)
59-59: Assumingyarn chartsis a valid command, this simplification aligns with the objective to streamline script execution.
60-60: The modification of theinfrascript to includeinstallaligns with the PR's objective to streamline the installation of infrastructure dependencies.
61-61: Introducing a newcliscript effectively consolidates script execution through a single entry point, simplifying the development process.
|
This is missing clean up of in the root readme and docs.devland. |
There was a problem hiding this comment.
Actionable comments posted: 1
Review Status
Configuration used: .coderabbit.yaml
Files selected for processing (2)
- package.json (1 hunks)
- scripts/infra-cmds.js (1 hunks)
Files skipped from review as they are similar to previous changes (1)
- package.json
Additional Context Used
Path-based Instructions (1)
scripts/infra-cmds.js (1)
Pattern
scripts/**/*: "Confirm that the code adheres to the following:
- Script efficiency, readability, and maintainability.
- Usage of environmental variables and configuration files for flexibility.
- Integration with NX workspace utilities and commands."
Additional comments not posted (2)
scripts/infra-cmds.js (2)
22-36: The custom formatting and logger setup using winston are correctly implemented and follow best practices.
44-46: Consider the security implications of usingspawnwithshell: true.
While the current usage seems safe, ensure that arguments passed tospawnare sanitized to prevent command injection vulnerabilities.Also applies to: 70-72
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #14352 +/- ##
==========================================
- Coverage 37.16% 36.94% -0.23%
==========================================
Files 6155 6139 -16
Lines 123889 124137 +248
Branches 35378 35491 +113
==========================================
- Hits 46049 45864 -185
- Misses 77840 78273 +433 Flags with carried forward coverage won't be shown. Click here to find out more. see 118 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
Datadog ReportAll test runs ✅ 73 Total Test Services: 0 Failed, 73 Passed Test ServicesThis report shows up to 10 services
|
* chore: remove postinstall script * fix: added infra-cmds wrapper * fix: e.message instead of e Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> --------- Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
infracmd to install infra deps,yarn infra.postinstallandpostinstall.jsscript, doesn't work in yarn v3yarn cliwill now run scripts in infraSummary by CodeRabbit
system-e2eREADME.package.json, including the introduction of a newcliscript and deprecation of theschemasscript in favor ofyarn codegen. Removed thepostinstallscript.yargsandwinstonfor logging in the newscripts/infra-cmds.jsfile. Includes commands for installing infrastructure dependencies and running various scripts defined in thepackage.jsonof the infrastructure module. Provides a warning message for deprecated usage.