Fix unreachable code error

oddsson · oddsson · commit c30625508a5b · 2024-09-18T14:22:05.000Z
diff --git a/apps/judicial-system/backend/src/app/modules/defendant/civilClaimant.service.ts b/apps/judicial-system/backend/src/app/modules/defendant/civilClaimant.service.ts
@@ -65,9 +65,8 @@ export class CivilClaimantService {
       this.logger.error(
         `Unexpected number of rows (${numberOfAffectedRows}) affected when deleting civil claimant ${civilClaimantId} of case ${caseId}`,
       )
-      if (numberOfAffectedRows < 1) {
-        throw new Error(`Could not delete civil claimant ${civilClaimantId}`)
-      }
+    } else if (numberOfAffectedRows < 1) {
+      throw new Error(`Could not delete civil claimant ${civilClaimantId}`)
     }
 
     return true

Original file line number	Diff line number	Diff line change
`@@ -65,9 +65,8 @@ export class CivilClaimantService {`
`65`	`65`	`this.logger.error(`
`66`	`66`	`Unexpected number of rows (${numberOfAffectedRows}) affected when deleting civil claimant ${civilClaimantId} of case ${caseId}`,
`67`	`67`	`)`
`68`		`- if (numberOfAffectedRows < 1) {`
`69`		- throw new Error(`Could not delete civil claimant ${civilClaimantId}`)
`70`		`- }`
	`68`	`+ } else if (numberOfAffectedRows < 1) {`
	`69`	+ throw new Error(`Could not delete civil claimant ${civilClaimantId}`)
`71`	`70`	`}`
`72`	`71`
`73`	`72`	`return true`