fix(citizenship): error with given and family names on prod (#15865)

* fixed name error and prune date for draft * fixed name error and prune date for draft --------- Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
island-is · Sep 3, 2024 · 9a67d75 · 9a67d75
1 parent 2ff3afd
commit 9a67d75
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 4 deletions.
diff --git a/...s/src/lib/modules/templates/directorate-of-immigration/citizenship/citizenship.service.ts b/...s/src/lib/modules/templates/directorate-of-immigration/citizenship/citizenship.service.ts
@@ -306,8 +306,11 @@ export class CitizenshipService extends BaseTemplateApiService {
             }
           }) || [],
         isFormerIcelandicCitizen: answers.formerIcelander === YES,
-        givenName: individual?.givenName,
-        familyName: individual?.familyName,
+        givenName:
+          individual?.givenName ||
+          individual?.fullName.split(' ').slice(0, -1).join(' '), //if given name is not available then remove last name and return the rest of the name as the given name
+        familyName:
+          individual?.familyName || individual?.fullName.split(' ').pop(),
         fullName: individual?.fullName,
         address: individual?.address?.streetAddress,
         postalCode: individual?.address?.postalCode,

diff --git a/...ration/citizenship/src/forms/CitizenshipForm/PersonalSection/UserInformationSubSection.ts b/...ration/citizenship/src/forms/CitizenshipForm/PersonalSection/UserInformationSubSection.ts
@@ -58,7 +58,7 @@ export const UserInformationSubSection = buildSubSection({
               undefined,
             ) as NationalRegistryIndividual | undefined
 
-            return `${individual?.givenName} ${individual?.familyName}`
+            return individual?.fullName
           },
         }),
         buildTextField({

diff --git a/...plication/templates/directorate-of-immigration/citizenship/src/lib/CitizenshipTemplate.ts b/...plication/templates/directorate-of-immigration/citizenship/src/lib/CitizenshipTemplate.ts
@@ -120,7 +120,7 @@ const template: ApplicationTemplate<
               },
             ],
           },
-          lifecycle: pruneAfterDays(1),
+          lifecycle: pruneAfterDays(30),
           onExit: defineTemplateApi({
             action: ApiActions.validateApplication,
           }),