Skip to content

Commit 6df9d85

Browse files
committed
Changed lambda to lambda_penalty in orient_normals_consistent_tangent_plane.
`lambda` is a reserved keyword in python and causes mypy to complain.
1 parent 230a9a6 commit 6df9d85

File tree

2 files changed

+6
-6
lines changed

2 files changed

+6
-6
lines changed

cpp/pybind/geometry/pointcloud.cpp

+1-1
Original file line numberDiff line numberDiff line change
@@ -146,7 +146,7 @@ void pybind_pointcloud_definitions(py::module &m) {
146146
&PointCloud::OrientNormalsConsistentTangentPlane,
147147
"Function to orient the normals with respect to consistent "
148148
"tangent planes",
149-
"k"_a, "lambda"_a = 0.0, "cos_alpha_tol"_a = 1.0)
149+
"k"_a, "lambda_penalty"_a = 0.0, "cos_alpha_tol"_a = 1.0)
150150
.def("compute_point_cloud_distance",
151151
&PointCloud::ComputePointCloudDistance,
152152
"For each point in the source point cloud, compute the "

cpp/pybind/t/geometry/pointcloud.cpp

+5-5
Original file line numberDiff line numberDiff line change
@@ -327,17 +327,17 @@ infinite value. It also removes the corresponding attributes.
327327
pointcloud.def(
328328
"orient_normals_consistent_tangent_plane",
329329
&PointCloud::OrientNormalsConsistentTangentPlane, "k"_a,
330-
"lambda"_a = 0.0, "cos_alpha_tol"_a = 1.0,
330+
"lambda_penalty"_a = 0.0, "cos_alpha_tol"_a = 1.0,
331331
R"(Function to consistently orient the normals of a point cloud based on tangent planes.
332332
333333
The algorithm is described in Hoppe et al., "Surface Reconstruction from Unorganized Points", 1992.
334-
Additional information about the choice of lambda and cos_alpha_tol for complex
334+
Additional information about the choice of lambda_penalty and cos_alpha_tol for complex
335335
point clouds can be found in Piazza, Valentini, Varetti, "Mesh Reconstruction from Point Cloud", 2023
336336
(https://eugeniovaretti.github.io/meshreco/Piazza_Valentini_Varetti_MeshReconstructionFromPointCloud_2023.pdf).
337337
338338
Args:
339339
k (int): Number of neighbors to use for tangent plane estimation.
340-
lambda (float): A non-negative real parameter that influences the distance
340+
lambda_penalty (float): A non-negative real parameter that influences the distance
341341
metric used to identify the true neighbors of a point in complex
342342
geometries. It penalizes the distance between a point and the tangent
343343
plane defined by the reference point and its normal vector, helping to
@@ -350,7 +350,7 @@ point clouds can be found in Piazza, Valentini, Varetti, "Mesh Reconstruction fr
350350
Example:
351351
We use Bunny point cloud to compute its normals and orient them consistently.
352352
The initial reconstruction adheres to Hoppe's algorithm (raw), whereas the
353-
second reconstruction utilises the lambda and cos_alpha_tol parameters.
353+
second reconstruction utilises the lambda_penalty and cos_alpha_tol parameters.
354354
Due to the high density of the Bunny point cloud available in Open3D a larger
355355
value of the parameter k is employed to test the algorithm. Usually you do
356356
not have at disposal such a refined point clouds, thus you cannot find a
@@ -375,7 +375,7 @@ point clouds can be found in Piazza, Valentini, Varetti, "Mesh Reconstruction fr
375375
poisson_mesh.compute_vertex_normals()
376376
o3d.visualization.draw_geometries([poisson_mesh])
377377
378-
# Case 2, reconstruction using lambda and cos_alpha_tol parameters:
378+
# Case 2, reconstruction using lambda_penalty and cos_alpha_tol parameters:
379379
pcd_robust = o3d.io.read_point_cloud(data.path)
380380
381381
# Compute normals and orient them consistently, using k=100 neighbours

0 commit comments

Comments
 (0)