Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

self.status is None: #291

Open
ianccole opened this issue Feb 7, 2024 · 0 comments · May be fixed by #293
Open

self.status is None: #291

ianccole opened this issue Feb 7, 2024 · 0 comments · May be fixed by #293

Comments

@ianccole
Copy link

ianccole commented Feb 7, 2024

Verify() assumes that KEY_CONSIDERED is never the first line parsed as it will append this to an existing self.status

See here:

self.status = '\n'.join([self.status, "key considered"])

But this is my output from the CL:


vagrant@UK01MBTSP-vm:~/dvt-prodtest-uk$ gpg --no-options --no-emit-version --no-tty --status-fd 2 --verify tests/sample_limits/med_pcba_p9_and_above_032_orig.lim 
[GNUPG:] NEWSIG
gpg: Signature made Wed 26 Oct 2022 10:52:20 BST
gpg:                using DSA key F96C4AF3CF6F8F26
[GNUPG:] KEY_CONSIDERED 51ADFA4BD2C3E4A1F9DD7A40F96C4AF3CF6F8F26 0
[GNUPG:] SIG_ID B7Tvd7WNfRCjRig008b+rTEm5ak 2022-10-26 1666777940
[GNUPG:] KEY_CONSIDERED 51ADFA4BD2C3E4A1F9DD7A40F96C4AF3CF6F8F26 0
[GNUPG:] GOODSIG F96C4AF3CF6F8F26 Orthogon Engineer (Used to sign limits files) <[email protected]>
gpg: Good signature from "Orthogon Engineer (Used to sign limits files) <[email protected]>" [unknown]
[GNUPG:] VALIDSIG 51ADFA4BD2C3E4A1F9DD7A40F96C4AF3CF6F8F26 2022-10-26 1666777940 0 3 0 17 2 01 51ADFA4BD2C3E4A1F9DD7A40F96C4AF3CF6F8F26
[GNUPG:] TRUST_UNDEFINED 0 pgp
gpg: WARNING: This key is not certified with a trusted signature!
gpg:          There is no indication that the signature belongs to the owner.
Primary key fingerprint: 51AD FA4B D2C3 E4A1 F9DD  7A40 F96C 4AF3 CF6F 8F26

Personally - would change self.status = None to self.status = "" in 2 places:

self.status = None

self.status = None

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant