Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sign function incorrectly strips one trailing CRLF #286

Open
Avamander opened this issue Sep 30, 2022 · 0 comments
Open

Sign function incorrectly strips one trailing CRLF #286

Avamander opened this issue Sep 30, 2022 · 0 comments

Comments

@Avamander
Copy link

When trying to generate a valid signature according to RFC3156 I stumbled upon the fact that the last \r\n of the bytes given to sign are stripped.

Example:

text = "example text\r\n".encode()
signature = sign(text)
assert verify(signature, text) == True

> AssertionError

Workaround:

text = "example text\r\n".encode()
signature = sign(text + "\r\n".encode())
assert verify(signature, text) == True
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant