bgpd: Convert struct peer_connection to dynamically allocated

As part of the conversion to a `struct peer_connection` it will
be desirable to have 2 pointers one for when we open a connection
and one for when we receive a connection.  Start this actual
conversion over to this in `struct peer`.  If this sounds confusing
take a look at the bgp state machine for connections and how
it resolves the processing of this router opening -vs- this
router receiving an open.  At some point in time the state
machine decides that we are keeping one of the two connections.

Future commits will allow us to untangle the peer/doppelganger
duality with this abstraction.

Signed-off-by: Donald Sharp <[email protected]>

Author: donaldsharp

bgpd/bgp_bfd.c

@@ -56,7 +56,7 @@ static void bfd_session_status_update(struct bfd_session_params *bsp,
 		peer->last_reset = PEER_DOWN_BFD_DOWN;
 
 		/* rfc9384 */
-		if (BGP_IS_VALID_STATE_FOR_NOTIF(peer->connection.status))
+		if (BGP_IS_VALID_STATE_FOR_NOTIF(peer->connection->status))
 			bgp_notify_send(peer, BGP_NOTIFY_CEASE,
 					BGP_NOTIFY_CEASE_BFD_DOWN);
 

bgpd/bgp_bmp.c

@@ -703,7 +703,7 @@ static int bmp_peer_status_changed(struct peer *peer)
 	if (!bmpbgp)
 		return 0;
 
-	if (peer->connection.status == Deleted) {
+	if (peer->connection->status == Deleted) {
 		bbpeer = bmp_bgp_peer_find(peer->qobj_node.nid);
 		if (bbpeer) {
 			XFREE(MTYPE_BMP_OPEN, bbpeer->open_rx);
@@ -715,12 +715,12 @@ static int bmp_peer_status_changed(struct peer *peer)
 	}
 
 	/* Check if this peer just went to Established */
-	if ((peer->connection.ostatus != OpenConfirm) ||
+	if ((peer->connection->ostatus != OpenConfirm) ||
 	    !(peer_established(peer)))
 		return 0;
 
 	if (peer->doppelganger &&
-	    (peer->doppelganger->connection.status != Deleted)) {
+	    (peer->doppelganger->connection->status != Deleted)) {
 		bbpeer = bmp_bgp_peer_get(peer);
 		bbdopp = bmp_bgp_peer_find(peer->doppelganger->qobj_node.nid);
 		if (bbdopp) {

bgpd/bgp_dump.c

@@ -512,8 +512,8 @@ int bgp_dump_state(struct peer *peer)
 			bgp_dump_all.type);
 	bgp_dump_common(obuf, peer, 1); /* force this in as4speak*/
 
-	stream_putw(obuf, peer->connection.ostatus);
-	stream_putw(obuf, peer->connection.status);
+	stream_putw(obuf, peer->connection->ostatus);
+	stream_putw(obuf, peer->connection->status);
 
 	/* Set length. */
 	bgp_dump_set_size(obuf, MSG_PROTOCOL_BGP4MP);

bgpd/bgp_evpn.c

@@ -6462,7 +6462,7 @@ void bgp_reimport_evpn_routes_upon_martian_change(
 		if (CHECK_FLAG(peer->sflags, PEER_STATUS_GROUP))
 			continue;
 
-		if (peer->connection.status != Established)
+		if (peer->connection->status != Established)
 			continue;
 
 		if (CHECK_FLAG(peer->af_flags[afi][safi],