Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Longer nonce #1

Open
DemiMarie opened this issue Mar 4, 2017 · 4 comments
Open

Longer nonce #1

DemiMarie opened this issue Mar 4, 2017 · 4 comments

Comments

@DemiMarie
Copy link

A 96-bit nonce has an uncomfortably high likelyhood of collisions. We should instead use a long (256-bit) salt, and use the KDF to generate the nonce as well as the key.
@isfonzar
Copy link
Owner

isfonzar commented Mar 4, 2017

Agreed. Do you mind implementing those changes?

@DemiMarie
Copy link
Author

Note that this will break compatibility with old versions of files encrypted by this library. Is that acceptable?

@DemiMarie
Copy link
Author

We should probably include a magic number in the file.

@isfonzar
Copy link
Owner

isfonzar commented Mar 6, 2017

Yes, it's still on beta.
We can make different releases so files encrypted with older versions can be retrieved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@DemiMarie @isfonzar