New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tokenization option `min_word_length` counts length in bytes #5

Open

isaackd opened this issue Apr 9, 2023 · 0 comments

Labels

bug

Owner

isaackd commented Apr 9, 2023

This should count by actual "characters"
https://github.com/isaackd/wcloud-dev/blob/e368d53dd4d6fb7fcef084ed98225dc54a054a29/src/tokenizer.rs#L46-L48
From https://doc.rust-lang.org/std/primitive.str.html#method.len:

This length is in bytes, not chars or graphemes. In other words, it might not be what a human considers the length of the string.

isaackd added the bug label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment