Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate from github.com/gogo/protobuf/protoc-gen-gogo in make proto #1138

Open
6 tasks
afritzler opened this issue Oct 22, 2024 · 0 comments · May be fixed by #1139
Open
6 tasks

Migrate from github.com/gogo/protobuf/protoc-gen-gogo in make proto #1138

afritzler opened this issue Oct 22, 2024 · 0 comments · May be fixed by #1139
Assignees
Labels
enhancement New feature or request

Comments

@afritzler
Copy link
Member

Problem

The current protobuf generation uses the deprecated github.com/gogo/protobuf/protoc-gen-gogo. This poses risks such as lack of support, security vulnerabilities, and future incompatibility. We need to migrate to a maintained alternative.

Requirements

  1. Select Alternative:

    • Research supported protobuf generators, such as:
      • google.golang.org/protobuf/cmd/protoc-gen-go
      • buf.build
  2. Update Makefile:

    • Replace protoc-gen-gogo in the make proto command with the new tool.
  3. Adjust Protobuf Definitions:

    • Ensure compatibility with the new generator.
  4. Update Dependencies:

    • Remove protoc-gen-gogo and add the new generator.
  5. Testing:

    • Verify the generated code is equivalent and performs correctly.

Definition of Done

  • A new protobuf generator is selected and integrated.
  • Makefile is updated to use the new generator.
  • Dependencies are updated.
  • Protobuf files are regenerated without issues.
  • No regressions or breaking changes occur.
  • Documentation is updated for the new protobuf setup.
@afritzler afritzler added the enhancement New feature or request label Oct 22, 2024
@afritzler afritzler added this to Core Oct 22, 2024
@afritzler afritzler moved this to Todo in Core Oct 22, 2024
@afritzler afritzler self-assigned this Oct 22, 2024
@afritzler afritzler linked a pull request Oct 25, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: 📋 Todo
Development

Successfully merging a pull request may close this issue.

1 participant