Assert affinity attribute present #22244
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
newling
force-pushed
the
assert_cast_is_not_null
branch
2 times, most recently
from
d8174b5 to
62560d5
Compare
Signed-off-by: James Newling <[email protected]>
Contributor
Author
|
CI passed. So what I observed previously, where the value passed to dyn_cast was null, was a flake. I think we should land this to see if that flake reappears. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The function
IREE::Stream::AffinityAttr::lookupOrDefaultmight return null. Discussion in #22241 suggests that, at the point it is called in this PR, it should really never be null. Assert that this is the case.