Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warning mismatches on tensorflow macos #4489

Closed
stellaraccident opened this issue Jan 12, 2021 · 2 comments
Closed

Warning mismatches on tensorflow macos #4489

stellaraccident opened this issue Jan 12, 2021 · 2 comments
Labels
infrastructure Relating to build systems, CI, or testing platform/macos 🍎 MacOS-specific build, execution, benchmarking, and deployment

Comments

@stellaraccident
Copy link
Collaborator

stellaraccident commented Jan 12, 2021

2021-01-12T11:06:17.7726980Z �[1mexternal/org_tensorflow/tensorflow/compiler/mlir/tensorflow/ir/tf_traits.h:91:20: �[0m�[0;1;31merror: �[0m�[1mloop variable 'operand_type' is always a copy because the range of type 'mlir::Operation::operand_type_range' (aka 'ValueTypeRange<mlir::OperandRange>') does not return a reference [-Werror,-Wrange-loop-analysis]�[0m
2021-01-12T11:06:17.7729510Z   for (const auto& operand_type : op->getOperandTypes()) {
2021-01-12T11:06:17.7735430Z �[0;1;32m                   ^
2021-01-12T11:06:17.7737130Z �[0m�[1mexternal/org_tensorflow/tensorflow/compiler/mlir/tensorflow/ir/tf_traits.h:91:8: �[0m�[0;1;30mnote: �[0muse non-reference type 'mlir::Type'�[0m
2021-01-12T11:06:17.7738980Z   for (const auto& operand_type : op->getOperandTypes()) {
2021-01-12T11:06:17.7740020Z �[0;1;32m       ^~~~~~~~~~~~~~~~~~~~~~~~~~
2021-01-12T11:06:17.7740760Z �[0m2 errors generated.
2021-01-12T11:06:17.7716040Z �[1mexternal/org_tensorflow/tensorflow/core/framework/type_index.h:61:17: �[0m�[0;1;31merror: �[0m�[1munused variable 'hash_bit' [-Werror,-Wunused-variable]�[0m
2021-01-12T11:06:17.7717460Z     static bool hash_bit[1];
2021-01-12T11:06:17.7718690Z �[0;1;32m             

I am considering just not making warnings errors for tensorflow on macos. I just don't think there is a lot of value in traipsing down these issues in someone else's project.

@stellaraccident stellaraccident added platform/macos 🍎 MacOS-specific build, execution, benchmarking, and deployment infrastructure/bazel labels Jan 12, 2021
@GMNGeoffrey GMNGeoffrey added the infrastructure Relating to build systems, CI, or testing label May 11, 2021
@GMNGeoffrey
Copy link
Contributor

I think this would be fixed by #9306 as well

@GMNGeoffrey GMNGeoffrey added this to IREE Jun 28, 2022
@github-project-automation github-project-automation bot moved this to Not Started in (Deprecated) IREE Feb 21, 2023
@allieculp allieculp moved this from Not Started to Inbox in (Deprecated) IREE Apr 5, 2023
@allieculp allieculp moved this from Inbox to Backlog in (Deprecated) IREE Apr 11, 2023
@ScottTodd
Copy link
Member

Obsolete - we no longer build TensorFlow from C++ sources.

@ScottTodd ScottTodd closed this as not planned Won't fix, can't repro, duplicate, stale Dec 15, 2023
@github-project-automation github-project-automation bot moved this from Backlog to Done in (Deprecated) IREE Dec 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
infrastructure Relating to build systems, CI, or testing platform/macos 🍎 MacOS-specific build, execution, benchmarking, and deployment
Projects
No open projects
Status: No status
Development

No branches or pull requests

4 participants