[DispatchCreation] Move concat decomposition to Dispatch creation and only decompose non-outer dim concats #19148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaheshRavishankar
force-pushed
the
concat_to_flow_move_pass
branch
3 times, most recently
from
78d1bdc
to
b9ebc4a
Compare
Signed-off-by: MaheshRavishankar <[email protected]>
Signed-off-by: MaheshRavishankar <[email protected]>
Signed-off-by: MaheshRavishankar <[email protected]>
MaheshRavishankar
force-pushed
the
concat_to_flow_move_pass
branch
from
b9ebc4a
to
9fe13d1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move the pass to decompose concats just before dispatch region formation, and only decompose concats that are not along the outer-most dimension. This could allow folding these insert-slices into their producers.
Outer dim concats are not decomposed here. They are left till flow conversion. Decomposing those into
flow.tensor.updateallows stream allocation to do the concat in-place.Fixes #19092
Depends on #19126 and llvm/llvm-project#116004