-
Notifications
You must be signed in to change notification settings - Fork 625
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document iree.build package #19019
Comments
Thanks. It really needs a handful more patches and a first use or two for me to stand behind it. Soon. Need it for some very near term priorities. |
I started trying out the We also have downstream usage in shortfin here: https://github.com/nod-ai/shark-ai/blob/main/shortfin/python/shortfin_apps/sd/components/builders.py. |
Thanks |
I think that there are likely some API wrappers that would make single shot cases work well, in addition to the more complicated pipeline cases |
For https://github.com/iree-org/iree-test-suites/blob/main/onnx_ops/import_onnx_tests.py, which I started migrating to use def import_action(folder_with_upstream_onnx_test_case):
# .onnx -> .mlir
import_onnx(folder / "model.onnx")
# input_0.pb, input_1.pb, ..., input_n.pb --> input_0.bin, ...
# output_0.pb, ... -> output_0.bin, ...
# run_module_io_flags.txt
import_test_inputs_and_outputs_from_pb_to_bin(folder)
for test_case in test_cases: # around 1000 of these
# Enqueue a build task for the test case. Each of these is independent.
import_action(test_case) So at least one custom build action to convert the .pb upstream test files to .bin IREE test files, then ~1000 groups of actions that can run in parallel. Right now I'm using Since the build graph goes wide instead of deep, I'm not sure if using I also found a few spots where the code could be reworked to better support Windows, like iree/compiler/bindings/python/iree/build/executor.py Lines 323 to 334 in 1aada43
- if not path.startswith("/"):
+ if not Path(path).is_absolute(): I'll send a PR once I'm a bit further along. |
…19236) Progress on #19019 and #5477. We have API documentation for the Python APIs hosted at https://iree-python-api.readthedocs.io/, but it has been pretty neglected, to the point where that URL is buried at https://iree.dev/reference/bindings/python/#usage. I'm not actually sure if any users have found that page (readthedocs does provide traffic data analytics, but we don't have enough views for that to register). This makes a few incremental improvements while I learn my way around Sphinx and what we have already for doc configuration, docstrings in source files, packages, etc. * Updated documentation for building the Sphinx website locally and recommended developers use `sphinx-autobuild` * Added an initial page for the `iree.build` package * Used code blocks in more places consistently, and closed some that were opened without closing ` characters * Fixed a few other warnings from Sphinx (wrong indentation, section delimiters not using enough characters, etc.) * Worked around a weird style issue with some custom css * Bumped the copyright year (as we do for https://iree.dev)
Published initial API docs: https://iree-python-api.readthedocs.io/en/latest/compiler/build.html |
These PRs have started implementing a new
iree.build
package:turbine_generate
iree.build rule. iree-turbine#249Documentation tasks:
Other related tasks:
We could wait until more of the package architecture and usage solidifies, but trying it out early would help inform the design.
The text was updated successfully, but these errors were encountered: