Update translation info related attributes #283
Conversation
This PR updates the dispatch codegen to use the new attributes for translation info. Also updates the ci requirements to last night's pre-release to get the latest changes. Signed-off-by: Harsh Menon <[email protected]>
harsh-nod
force-pushed
the
new_changes
branch
from
29a8b05
to
fd07092
Compare
harsh-nod
requested review from
ScottTodd,
raikonenfnu,
Hardcode84 and
martin-luecke
iree-requirements-ci.txt
Outdated
| @@ -10,5 +10,5 @@ | |||
| # Uncomment to skip versions from PyPI (so _only_ nightly versions). | |||
| # --no-index | |||
|
|
|||
| iree-base-compiler<=3.0.0 | |||
| iree-base-runtime<=3.0.0 | |||
| iree-base-compiler<=3.1.0rc20241120 | |||
There was a problem hiding this comment.
I think it should be >= or even == as older version will no longer work.
There was a problem hiding this comment.
The CI passed without uncommenting
# Uncomment to select a nightly version.
# --find-links https://iree.dev/pip-release-links.html
# --pre
and jobs just installed 3.0.0: https://github.com/iree-org/iree-turbine/actions/runs/11938126768/job/33275707429?pr=283#step:5:47
... so this might not even be needed. Which IREE commit do you want to bump past?
There was a problem hiding this comment.
I want this commit included : iree-org/iree@8fd3e0d
There was a problem hiding this comment.
Do you know which nightly release this commit would be in?
There was a problem hiding this comment.
I think it should be
>=or even==as older version will no longer work.
makes sense, okay will change to ==.
There was a problem hiding this comment.
Make sense, thanks for the explanation. I need that commit for this PR: #284 which will fail without it, but I will update the ci in the commit to pick up tonight's pre-release.
There was a problem hiding this comment.
Gotcha. You can monitor for pre-releases at https://github.com/iree-org/iree/releases .
You can also watch the commit itself to see when it gets associated with a release tag. For example, iree-org/iree@e3826d5 was included in all of these releases: iree-3.1.0rc20241120, iree-3.1.0rc20241119, iree-3.0.0, iree-3.0.0rc20241118, iree-3.0.0rc20241117, iree-3.0.0rc20241116
There was a problem hiding this comment.
That's pretty cool, thanks for sharing. Since this change doesn't need any updates to the iree requirements, I will leave it as is and change the requirements with the other PR tomorrow.
There was a problem hiding this comment.
Actually @raikonenfnu it turns out that on CDNA2, if I use the old version of iree I get a failure with attention. But with the latest, it is passing. So I will keep this for now and we can investigate further.
There was a problem hiding this comment.
that is odd though, I wasn't getting any attention failures on CDNA2, when working on the PR yesterday and this morning..
harsh-nod
force-pushed
the
new_changes
branch
from
a6ff00f
to
501952d
Compare
harsh-nod
force-pushed
the
new_changes
branch
from
501952d
to
9bb1833
Compare
Signed-off-by: Harsh Menon <[email protected]>
harsh-nod
force-pushed
the
new_changes
branch
from
9bb1833
to
f28c361
Compare
This PR updates the dispatch codegen to use the
new attributes for translation info. Also updates
the ci requirements to last night's pre-release
to get the latest changes.