-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test against Stargate/Tendermint 0.34 #144
Comments
We're wrapping up a major overhaul to tendermint-rs this week and should be able to help update the KMS to it - includes dropping all Amino and replacing with protobuf. |
Current testing status is we've managed to have TMKMS complete the secret connection handshake with Tendermint v0.34 on the It's managed to sign blocks and respond, however the signature/canonicalization logic is still using Amino encoding, so the signatures were rejected:
|
TMKMS is definitely Stargate-compatible at this point |
Tendermint 0.34 is expected to be backwards compatible in the block signing proposal.
It is possible to drop amino entirely and use protobuf for Tendermint 0.34 signing and we should but the bytes on the wire should be identical. We should validate this week.
@tony-iqlusion @Shella
The text was updated successfully, but these errors were encountered: