Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ipld libs #35

Merged
merged 1 commit into from
Sep 23, 2020
Merged

Update ipld libs #35

merged 1 commit into from
Sep 23, 2020

Conversation

hannahhoward
Copy link
Collaborator

Goals

Update Ipld libs to fairly recent version (lastest used by go-ipld-prime-proto

Implementation

Update deps, fix a couple naming changes (Style->Prototype)

update ipld libs to fairly recent version (lastest used by go-ipld-prime-proto
@codecov
Copy link

codecov bot commented Sep 23, 2020

Codecov Report

Merging #35 into master will decrease coverage by 4.79%.
The diff coverage is 75.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #35      +/-   ##
==========================================
- Coverage   55.83%   51.03%   -4.80%     
==========================================
  Files           3        3              
  Lines         283      241      -42     
==========================================
- Hits          158      123      -35     
+ Misses         89       83       -6     
+ Partials       36       35       -1     
Impacted Files Coverage Δ
selectivecar.go 65.42% <75.00%> (-3.13%) ⬇️
car.go 47.12% <0.00%> (-6.72%) ⬇️
util/util.go 25.53% <0.00%> (-5.38%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c222d79...3df2237. Read the comment docs.

@warpfork
Copy link
Contributor

warpfork commented Sep 23, 2020

Sidenote: codecov: I wanna tag this (if for nothing else than my own personal reference) as one of the kind of things that made me ditch the codecov service in some other projects. This report it made is... objectively and trivially nuts.

Claims coverage has gone down. Huge red squares. Looks like fire and klaxons. And it reports this as a "fail" of the check.

On a diff that's entirely renames, and has no flow changes whatsoever, and is line-for-line 1:1 the same length before and after in all code files.

Uffdah. No, codecov. That is not helpful.

@hannahhoward hannahhoward merged commit fcc7bb8 into master Sep 23, 2020
@aschmahmann aschmahmann mentioned this pull request Feb 18, 2021
73 tasks
@mvdan mvdan deleted the feat/update-to-ipld-prime branch June 25, 2021 12:29
Jorropo pushed a commit to ipfs/boxo that referenced this pull request Mar 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants