From 615456eb0f813ea4cdab01ceb5be472d2a169b95 Mon Sep 17 00:00:00 2001 From: Henrique Dias Date: Tue, 13 Dec 2022 11:17:50 +0100 Subject: [PATCH 1/2] docs: validity follows expiration window --- ipns/IPNS.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ipns/IPNS.md b/ipns/IPNS.md index cb4293246..a9f6596d0 100644 --- a/ipns/IPNS.md +++ b/ipns/IPNS.md @@ -132,7 +132,7 @@ A logical IPNS record is a data structure containing the following fields: - Implementations MUST support `validityType = 0` and include this value in both `IpnsEntry.validityType` and inside the DAG-CBOR document at `IpnsEntry.data[validityType]`. - **Validity** (bytes) - When `validityType = 0` - - Expiration date of the record with nanoseconds precision. + - Expiration date of the record with nanoseconds precision. We suggest this value to follow the expiration window of the publishing medium. For example, records published in the DHT should expire 48 hours after being published. - Represented as an ASCII string that follows notation from [RFC3339](https://www.ietf.org/rfc/rfc3339.txt) (`1970-01-01T00:00:00.000000001Z`). - Implementations MUST include this value in both `IpnsEntry.validity` and inside the DAG-CBOR document at `IpnsEntry.data[validity]`. - **Sequence** (uint64) From ba619e8fefa5f6dd5d8822e49841894fdf4aa5d9 Mon Sep 17 00:00:00 2001 From: Marcin Rataj Date: Mon, 13 Feb 2023 18:39:33 +0100 Subject: [PATCH 2/2] style: clarify value >48h is ignored by dht --- ipns/IPNS.md | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/ipns/IPNS.md b/ipns/IPNS.md index a9f6596d0..c40be3aa9 100644 --- a/ipns/IPNS.md +++ b/ipns/IPNS.md @@ -132,7 +132,8 @@ A logical IPNS record is a data structure containing the following fields: - Implementations MUST support `validityType = 0` and include this value in both `IpnsEntry.validityType` and inside the DAG-CBOR document at `IpnsEntry.data[validityType]`. - **Validity** (bytes) - When `validityType = 0` - - Expiration date of the record with nanoseconds precision. We suggest this value to follow the expiration window of the publishing medium. For example, records published in the DHT should expire 48 hours after being published. + - Expiration date of the record with nanoseconds precision. Expiration time should match the publishing medium's window. + - For example, IPNS records published on the DHT should have an expiration time set to within 48 hours after publication. Setting the expiration time to longer than 48 hours will not have any effect, as DHT peers only keep records for up to 48 hours. - Represented as an ASCII string that follows notation from [RFC3339](https://www.ietf.org/rfc/rfc3339.txt) (`1970-01-01T00:00:00.000000001Z`). - Implementations MUST include this value in both `IpnsEntry.validity` and inside the DAG-CBOR document at `IpnsEntry.data[validity]`. - **Sequence** (uint64)