docs: clarify use of provider hints #72
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- makes it explicit that connection dials to origins and delegates are best-effort, and should not fail the pinning - swaps examples to use fully resolved multiaddrs, that can immediatelly be acted upon (IP ranges from test ranges (https://tools.ietf.org/html/rfc5737)
jessicaschilling
suggested changes
Feb 10, 2021
Co-authored-by: Jessica Schilling <[email protected]>
Co-authored-by: Jessica Schilling <[email protected]>
Co-authored-by: Jessica Schilling <[email protected]>
Co-authored-by: Jessica Schilling <[email protected]>
Co-authored-by: Jessica Schilling <[email protected]>
Co-authored-by: Jessica Schilling <[email protected]>
Co-authored-by: Jessica Schilling <[email protected]>
Co-authored-by: Jessica Schilling <[email protected]>
Co-authored-by: Jessica Schilling <[email protected]>
Co-authored-by: Jessica Schilling <[email protected]>
|
@jessicaschilling thank you, applied suggestions + made a small clarification in 84cec73 – mind taking a second look? |
jessicaschilling
approved these changes
Feb 10, 2021
|
Merging as I got 👍 from @aschmahmann and @obo20 via a telepathic medium of a great accuracy. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates docs and examples related to
originsanddelegatesmultiaddr arrays:Thanks to @obo20 for raising the ambiguity here – lmk if this clears things out.