-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
object plumbing commands #185
Conversation
ipfs object is a plumbing command used to manipulate dag objects directly. | ||
- <key> is a base58 encoded multihash. | ||
- It reads from stdin or writes to stdout. | ||
- It accepts multiple encodings: --encoding=[ protobuf, json, ... ]`, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if there are any other encodings we would want to support...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Depends on how nice we want to be. msgpack, xml, rdf, and so on do see some use.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, xml encoding might be nice to integrate with older systems
@cryptix awesome! thanks! a few comments up there, and one important note: this doesn't work with a daemon, right? it's reading from Probably fine for now until we figure out what the commands library makes it look like. We'll need a way to pass |
Jep, that's right. Same issue as with the block commands. Waiting for @mappum's cmd stuff |
@jbenet i just noticed that I didn't yet add the commands to the daemon. So it won't work anyhow in this state. |
@cryptix ok that's fine let's just merge it anyway and transition it to daemon later. |
@cryptix (aside from the wording stuff, which I'll fix post merge) there's a few comments up there to address? Like:
(At least the top two, i can handle the Codec interface if not of interest) |
Addressed the first two, not too sure where to place the codec interface and I think it's fine until we introduce more formats. |
don't double-validate values
updates #138