Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

object plumbing commands #185

Merged
merged 4 commits into from
Oct 19, 2014
Merged

object plumbing commands #185

merged 4 commits into from
Oct 19, 2014

Conversation

cryptix
Copy link
Contributor

@cryptix cryptix commented Oct 18, 2014

updates #138

ipfs object is a plumbing command used to manipulate dag objects directly.
- <key> is a base58 encoded multihash.
- It reads from stdin or writes to stdout.
- It accepts multiple encodings: --encoding=[ protobuf, json, ... ]`,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if there are any other encodings we would want to support...

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Depends on how nice we want to be. msgpack, xml, rdf, and so on do see some use.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, xml encoding might be nice to integrate with older systems

@jbenet
Copy link
Member

jbenet commented Oct 18, 2014

@cryptix awesome! thanks! a few comments up there, and one important note:

this doesn't work with a daemon, right? it's reading from os.Stdin, which is right on the client, but the code there will be executed in the daemon side, no?

Probably fine for now until we figure out what the commands library makes it look like. We'll need a way to pass io.Readers as arguments. cc @mappum

@cryptix
Copy link
Contributor Author

cryptix commented Oct 18, 2014

Jep, that's right. Same issue as with the block commands. Waiting for @mappum's cmd stuff

@cryptix
Copy link
Contributor Author

cryptix commented Oct 18, 2014

@jbenet i just noticed that I didn't yet add the commands to the daemon. So it won't work anyhow in this state.

@jbenet
Copy link
Member

jbenet commented Oct 18, 2014

@cryptix ok that's fine let's just merge it anyway and transition it to daemon later.

@jbenet
Copy link
Member

jbenet commented Oct 19, 2014

@cryptix (aside from the wording stuff, which I'll fix post merge) there's a few comments up there to address? Like:

(At least the top two, i can handle the Codec interface if not of interest)

@cryptix
Copy link
Contributor Author

cryptix commented Oct 19, 2014

Addressed the first two, not too sure where to place the codec interface and I think it's fine until we introduce more formats.

jbenet added a commit that referenced this pull request Oct 19, 2014
@jbenet jbenet merged commit 9e3bfa2 into ipfs:master Oct 19, 2014
@cryptix cryptix deleted the cmdObjects branch October 20, 2014 10:15
@jbenet jbenet mentioned this pull request Oct 23, 2014
ariescodescream pushed a commit to ariescodescream/go-ipfs that referenced this pull request Oct 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants