Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin ls stops traversing recursive pins after hitting a direct pin #6527

Closed
Stebalien opened this issue Jul 17, 2019 · 4 comments · Fixed by #6705
Closed

Pin ls stops traversing recursive pins after hitting a direct pin #6527

Stebalien opened this issue Jul 17, 2019 · 4 comments · Fixed by #6705
Labels
kind/bug A bug in existing code (including security flaws)
Milestone

Comments

@Stebalien
Copy link
Member

Stebalien commented Jul 17, 2019

We should avoid re-emitting these directly pinned blocks but we still need to continue traversing the tree. This needs a test to be considered fixed.

Regression from #6493.

@Stebalien Stebalien added the kind/bug A bug in existing code (including security flaws) label Jul 17, 2019
@lanzafame
Copy link
Contributor

@Stebalien Does this also mean that this case isn't covered by the current test set? I am guessing this was caught via manual testing as the tests passed in #6493.

@Stebalien
Copy link
Member Author

It is not covered by the current test set. I haven't actually reproduced this issue, I just happened to re-read the code...

@lanzafame
Copy link
Contributor

Can we add to this issue that the fix includes a test to cover this case?

@lanzafame
Copy link
Contributor

Just in case someone else picks up the fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug A bug in existing code (including security flaws)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants