Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cost of updating many small keys in Badgedb? #5593

Closed
kevina opened this issue Oct 12, 2018 · 3 comments
Closed

Cost of updating many small keys in Badgedb? #5593

kevina opened this issue Oct 12, 2018 · 3 comments
Assignees

Comments

@kevina
Copy link
Contributor

kevina commented Oct 12, 2018

One of the arguments against storing pinning information as part of an inode () is the cost of largescale updates.

This issue is to get a handle on the cost. If nothing us to document it.

@eingenito idea of not having to update every block when a pin is updated may help make this less important,

@Stebalien
Copy link
Member

@magik6k is this a known issue with badger?

@magik6k
Copy link
Member

magik6k commented May 16, 2019

Cost of updating keys should be roughly the same as just writing new ones, so that's not really an issue. The issue is GCing old versions (afaik updates to keys just leave old versions behind to be GCed).

@Stebalien
Copy link
Member

Got it. That should be fine given that ipfs/go-ds-badger#54 has been fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants