Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tell DHT nodes if their IPNS records are out of date #4954

Closed
Stebalien opened this issue Apr 20, 2018 · 0 comments · Fixed by #5007
Closed

Tell DHT nodes if their IPNS records are out of date #4954

Stebalien opened this issue Apr 20, 2018 · 0 comments · Fixed by #5007
Assignees
@Stebalien
Labels
kind/bug A bug in existing code (including security flaws)

Comments

@Stebalien
Copy link
Member

Due to #4733, we call GetValues instead of GetValue. Unfortunately, this means that the DHT never learns which value is correct so it never corrects peers with outdated values.

(also, the new getValue function on the routingResolver duplicates a lot of code in dht.GetValue)
@Stebalien Stebalien added the kind/bug A bug in existing code (including security flaws) label Apr 20, 2018
@Stebalien Stebalien mentioned this issue Apr 26, 2018
Closed
@Stebalien Stebalien mentioned this issue May 9, 2018
Merged
8 tasks
@ghost ghost assigned Stebalien May 9, 2018
@ghost ghost added the status/in-progress In progress label May 9, 2018
@ghost ghost removed the status/in-progress In progress label Jun 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Stebalien Stebalien

Labels
kind/bug A bug in existing code (including security flaws)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

routing fixes/refactor ipfs/kubo
1 participant
@Stebalien