Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove gx references to be usable as library #3920

Closed
abergmeier-dsfishlabs opened this issue May 12, 2017 · 7 comments
Closed

Remove gx references to be usable as library #3920

abergmeier-dsfishlabs opened this issue May 12, 2017 · 7 comments

Comments

@abergmeier-dsfishlabs
Copy link

I am trying to use go-ipfs in a personal project. Sadly, several go files have explicit references to "gx".
Since I am using Bazel to build my project, this mechanic is not working.
It would be great if go-ipfs would handle like a stock go project without the need for a specific build system/package manager.

@Kubuxu
Copy link
Member

Kubuxu commented May 12, 2017

It was discussed multiple times already:
#3327
#3648

@abergmeier-dsfishlabs
Copy link
Author

It was discussed multiple times already:
#3327
#3648

I do understand the problems with go's module system and the incentive to create/use gx.
On the other hand I would perhaps suggest you looking at Bazel. There you can reference third-party revisions AND have use standard go methods.

@whyrusleeping
Copy link
Member

@abergmeier-dsfishlabs with bazel you should be able to run gx-go uw on the go-ipfs source to change paths back to normal github paths.

@wigy-opensource-developer

@abergmeier-dsfishlabs After running through the Bazel tutorial, I still do not see how you can chose a given commit in a git repository for your build. If you want to get reproducible builds, you need to find a way to do that. gx is one way to achieve that reproducibility and you can integrate it into your build system as an external dependency: https://bazel.build/versions/master/docs/external.html#non-bazel-projects

@abergmeier-dsfishlabs
Copy link
Author

abergmeier-dsfishlabs commented May 15, 2017

After running through the Bazel tutorial, I still do not see how you can chose a given commit in a git repository for your build.

In your WORKSPACE file you would write:

git_repository(
    name = "io_ipfs_go-ipfs",
    commit = "a4ffefd2ad6207758669d07e30acd52f74dc4f09",
    remote = "https://github.com/ipfs/go-ipfs.git",
)

I will probably fork, remove gx, add Bazel and merge every release into my fork.

@whyrusleeping
Copy link
Member

Closing

@anacrolix
Copy link
Contributor

See now #5850 and #5848.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants