Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

abstract out dht routing table #118

Closed
jbenet opened this issue Sep 24, 2014 · 4 comments
Closed

abstract out dht routing table #118

jbenet opened this issue Sep 24, 2014 · 4 comments

Comments

@jbenet
Copy link
Member

jbenet commented Sep 24, 2014

We need to:

  • remove levels stuff for now
  • abstract out dht routing table
  • implement coral levels as another impl
@whyrusleeping
Copy link
Member

im unsure how an interface for that would feel... we would need something like: "GetPeers" and then "GetMorePeers"

@jbenet
Copy link
Member Author

jbenet commented Sep 29, 2014

Perhaps, the right thing to do is something like this:

type DHT interface {
  FindPeersNear(context.Context, u.Key) <-chan *peer.Peer
}

Because we can keep the goroutine fetching more and more close peers (with some rate-limit) until it's cancelled.

Rate limiting can happen in the context (WithValue).

@whyrusleeping
Copy link
Member

alright, i like that.

@whyrusleeping
Copy link
Member

closing, not an issue for now, may be in the future, can reopen later if necessary (or just start a new issue)

@aschmahmann aschmahmann mentioned this issue Feb 18, 2021
73 tasks
ariescodescream pushed a commit to ariescodescream/go-ipfs that referenced this issue Oct 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants