-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add back controller.api.gatewayHost
and controller.api.gatewayPort
or similar
#831
Labels
need/triage
Needs initial labeling and prioritization
Comments
This was referenced May 3, 2024
we should call |
it doesn't seem like create code:
and the output:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
With the latest update from #823 we no longer have the ability to get the listening ipfs gateway host and port from the instantiated kubo node.
this forces consumers to do handle passing around port/host config passed to
createNode
or parsing config options from the createdKuboNode
using https://github.com/multiformats/js-multiaddr-to-uriWe shouldn't need to do this on the consumer side because ipfsd-ctl and kubo-rpc-client should both have the gateway URL readily accessible.
We should expose this on the
await node.info()
result.The text was updated successfully, but these errors were encountered: