This repository has been archived by the owner on Mar 10, 2020. It is now read-only.
fix: remove argument from .stats.bw* #699
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
daviddias
suggested changes
Feb 22, 2018
| @@ -5,7 +5,7 @@ const pump = require('pump') | |||
| const transformChunk = require('./bw-util') | |||
|
|
|||
| module.exports = (send) => { | |||
| return (hash, opts) => { | |||
| return (opts) => { | |||
There was a problem hiding this comment.
Hm.. how doesn't this change break tests?
There was a problem hiding this comment.
No because we're not testing the options yet. Although the build failed due to 'JavaScript heap out of memory'.
daviddias
approved these changes
Feb 22, 2018
dryajov
pushed a commit
that referenced
this pull request
Feb 23, 2018
* Update bw-readable-stream.js * Update bw-pull-stream.js
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removing an argument that wasn't supposed to exist.