Skip to content
This repository has been archived by the owner on Mar 10, 2020. It is now read-only.

Pubsub do not eat error messages #632

Merged
merged 3 commits into from
Nov 22, 2017
Merged

Pubsub do not eat error messages #632

merged 3 commits into from
Nov 22, 2017

Conversation

richardschneider
Copy link
Contributor

No description provided.

@ghost ghost added the in progress label Nov 21, 2017
@codecov
Copy link

codecov bot commented Nov 22, 2017

Codecov Report

Merging #632 into master will decrease coverage by 0.32%.
The diff coverage is 85.71%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #632      +/-   ##
==========================================
- Coverage   84.08%   83.76%   -0.33%     
==========================================
  Files         115      112       -3     
  Lines        1747     1626     -121     
==========================================
- Hits         1469     1362     -107     
+ Misses        278      264      -14
Impacted Files Coverage Δ
src/pubsub.js 79.72% <ø> (ø) ⬆️
src/utils/pubsub-message-utils.js 64.28% <100%> (-7.15%) ⬇️
src/utils/pubsub-message-stream.js 93.33% <83.33%> (-6.67%) ⬇️
src/files/write.js 80% <0%> (-10.91%) ⬇️
src/files/add.js 89.65% <0%> (-10.35%) ⬇️
src/object/setData.js 29.41% <0%> (-8.69%) ⬇️
src/object/appendData.js 82.35% <0%> (-3.37%) ⬇️
src/object/put.js 90% <0%> (-0.77%) ⬇️
src/files/add-readable-stream.js 100% <0%> (ø) ⬆️
... and 15 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 21596c7...b99958d. Read the comment docs.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants